Bug 84486 – Crash in getOrDrawNodeHighlight after r114659

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Xianzhu Wang]

See crbug.com/124382.

[Xianzhu Wang]

Created attachment 138155 [details]
patch

[Jer Noble]

*** Bug 84492 has been marked as a duplicate of this bug. ***

[Jer Noble]

Comment on attachment 138155 [details]
patch

Looks good to me.  After applying the patch, the crash no longer occurs on that test.

[Jer Noble]

And by "that test", I mean inspector/elements/elements-panel-selection-on-refresh.html, which was the crashing test in bug 84492, which was marked as a dup of this bug.

[Daniel Bates]

Comment on attachment 138155 [details]
patch

Looks good to me.

For completeness, Jer Noble told me on IRC that the test case inspector/elements/elements-panel-selection-on-refresh.html covers this crash.

[Daniel Bates]

Comment on attachment 138155 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138155&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. Just a quick fix of a crash caused by r114659.

Per comment 5, I suggest that we mention that this fix is covered by test inspector/elements/elements-panel-selection-on-refresh.html.

[Xianzhu Wang]

Created attachment 138167 [details]
patch for landing

Test case mentioned in ChangeLog. Thanks for review!

[Jer Noble]

Committed r114783: <http://trac.webkit.org/changeset/114783>

[Daniel Bates]

Comment on attachment 138167 [details]
patch for landing

cq-'ing this patch since it landed in <http://trac.webkit.org/changeset/114783>.

[Jer Noble]

(In reply to comment #7)
> Created an attachment (id=138167) [details]
> patch for landing
> 
> Test case mentioned in ChangeLog. Thanks for review!

Landed this patch manually.  (I updated the ChangeLog to mention the crashing test, so my wording is not exactly the same as your most recently uploaded patch, but the meaning is there.) :)