In WK1 touch-point area is now converted from QTouchEvent::TouchPoint to PlatformTouchPoint, but it's missing from WK2.
Created attachment 138069 [details] Patch
Comment on attachment 138069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138069&action=review > Source/WebKit2/ChangeLog:6 > + [Qt][WK2] Convert touch-point area. > + https://bugs.webkit.org/show_bug.cgi?id=84434 > + > + Reviewed by NOBODY (OOPS!). it would be nicer with more descriptive changelogs explaining why this is a good idea and what it means etc.
(In reply to comment #2) > (From update of attachment 138069 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138069&action=review > > > Source/WebKit2/ChangeLog:6 > > + [Qt][WK2] Convert touch-point area. > > + https://bugs.webkit.org/show_bug.cgi?id=84434 > > + > > + Reviewed by NOBODY (OOPS!). > > it would be nicer with more descriptive changelogs explaining why this is a good idea and what it means etc. Okay. I left it out because it was really just an omission from a previous patch. It means dom touch-events when accessed from javascript does not have radius (and pressure) parameters. Well, at least not if the event comes from WebKit2, from WebKit1 the conversion is already handled.
Comment on attachment 138069 [details] Patch Please add a bit more info to the changelog
Created attachment 138363 [details] Patch for landing
Comment on attachment 138363 [details] Patch for landing missed new files
Created attachment 138364 [details] Patch for landing
Comment on attachment 138364 [details] Patch for landing Clearing flags on attachment: 138364 Committed r114917: <http://trac.webkit.org/changeset/114917>
All reviewed patches have been landed. Closing bug.
Reopen, because fast/events/touch/basic-single-touch-events.html started to fail after this change. http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/r114919%20%281606%29/fast/events/touch/basic-single-touch-events-pretty-diff.html
I skipped it to make the bot happier a little bit - http://trac.webkit.org/changeset/115010/trunk/LayoutTests/platform/qt-5.0-wk2/Skipped Please unskip it with the proper fix.
(In reply to comment #12) > I skipped it to make the bot happier a little bit - http://trac.webkit.org/changeset/115010/trunk/LayoutTests/platform/qt-5.0-wk2/Skipped > > Please unskip it with the proper fix. It looks like the bot is not running with the new DumpRenderTree function.
Do you use the latest pinned Qt5 hash?
Created attachment 138550 [details] Patch for failing test Also adds the new EventSender API to WebKitTestRunner
Comment on attachment 138550 [details] Patch for failing test Clearing flags on attachment: 138550 Committed r115071: <http://trac.webkit.org/changeset/115071>
Committed r117245: <http://trac.webkit.org/changeset/117245>