Bug 84434 - [Qt][WK2] Convert touch-point area
Summary: [Qt][WK2] Convert touch-point area
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 79666
  Show dependency treegraph
 
Reported: 2012-04-20 04:48 PDT by Allan Sandfeld Jensen
Modified: 2012-05-16 02:43 PDT (History)
5 users (show)

See Also:


Attachments
Patch (12.66 KB, patch)
2012-04-20 04:53 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Patch for landing (9.12 KB, patch)
2012-04-23 09:25 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Patch for landing (12.70 KB, patch)
2012-04-23 09:30 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Patch for failing test (8.11 KB, patch)
2012-04-24 06:46 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-04-20 04:48:41 PDT
In WK1 touch-point area is now converted from QTouchEvent::TouchPoint to PlatformTouchPoint, but it's missing from WK2.
Comment 1 Allan Sandfeld Jensen 2012-04-20 04:53:53 PDT
Created attachment 138069 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-04-20 09:21:28 PDT
Comment on attachment 138069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138069&action=review

> Source/WebKit2/ChangeLog:6
> +        [Qt][WK2] Convert touch-point area.
> +        https://bugs.webkit.org/show_bug.cgi?id=84434
> +
> +        Reviewed by NOBODY (OOPS!).

it would be nicer with more descriptive changelogs explaining why this is a good idea and what it means etc.
Comment 3 Kenneth Rohde Christiansen 2012-04-20 09:21:32 PDT
Comment on attachment 138069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138069&action=review

> Source/WebKit2/ChangeLog:6
> +        [Qt][WK2] Convert touch-point area.
> +        https://bugs.webkit.org/show_bug.cgi?id=84434
> +
> +        Reviewed by NOBODY (OOPS!).

it would be nicer with more descriptive changelogs explaining why this is a good idea and what it means etc.
Comment 4 Allan Sandfeld Jensen 2012-04-21 06:27:31 PDT
(In reply to comment #2)
> (From update of attachment 138069 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138069&action=review
> 
> > Source/WebKit2/ChangeLog:6
> > +        [Qt][WK2] Convert touch-point area.
> > +        https://bugs.webkit.org/show_bug.cgi?id=84434
> > +
> > +        Reviewed by NOBODY (OOPS!).
> 
> it would be nicer with more descriptive changelogs explaining why this is a good idea and what it means etc.

Okay. I left it out because it was really just an omission from a previous patch. It means dom touch-events when accessed from javascript does not have radius (and pressure) parameters. Well, at least not if the event comes from WebKit2, from WebKit1 the conversion is already handled.
Comment 5 Kenneth Rohde Christiansen 2012-04-21 09:39:23 PDT
Comment on attachment 138069 [details]
Patch

Please add a bit more info to the changelog
Comment 6 Allan Sandfeld Jensen 2012-04-23 09:25:52 PDT
Created attachment 138363 [details]
Patch for landing
Comment 7 Allan Sandfeld Jensen 2012-04-23 09:27:33 PDT
Comment on attachment 138363 [details]
Patch for landing

missed new files
Comment 8 Allan Sandfeld Jensen 2012-04-23 09:30:25 PDT
Created attachment 138364 [details]
Patch for landing
Comment 9 WebKit Review Bot 2012-04-23 10:37:15 PDT
Comment on attachment 138364 [details]
Patch for landing

Clearing flags on attachment: 138364

Committed r114917: <http://trac.webkit.org/changeset/114917>
Comment 10 WebKit Review Bot 2012-04-23 10:37:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Csaba Osztrogonác 2012-04-24 01:31:31 PDT
Reopen, because fast/events/touch/basic-single-touch-events.html started to fail after this change.

http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/r114919%20%281606%29/fast/events/touch/basic-single-touch-events-pretty-diff.html
Comment 12 Csaba Osztrogonác 2012-04-24 01:36:00 PDT
I skipped it to make the bot happier a little bit - http://trac.webkit.org/changeset/115010/trunk/LayoutTests/platform/qt-5.0-wk2/Skipped

Please unskip it with the proper fix.
Comment 13 Allan Sandfeld Jensen 2012-04-24 01:39:05 PDT
(In reply to comment #12)
> I skipped it to make the bot happier a little bit - http://trac.webkit.org/changeset/115010/trunk/LayoutTests/platform/qt-5.0-wk2/Skipped
> 
> Please unskip it with the proper fix.

It looks like the bot is not running with the new DumpRenderTree function.
Comment 14 Csaba Osztrogonác 2012-04-24 03:35:54 PDT
Do you use the latest pinned Qt5 hash?
Comment 15 Allan Sandfeld Jensen 2012-04-24 06:46:10 PDT
Created attachment 138550 [details]
Patch for failing test

Also adds the new EventSender API to WebKitTestRunner
Comment 16 WebKit Review Bot 2012-04-24 09:28:37 PDT
Comment on attachment 138550 [details]
Patch for failing test

Clearing flags on attachment: 138550

Committed r115071: <http://trac.webkit.org/changeset/115071>
Comment 17 WebKit Review Bot 2012-04-24 09:28:43 PDT
All reviewed patches have been landed.  Closing bug.
Comment 18 Jocelyn Turcotte 2012-05-16 02:43:10 PDT
Committed r117245: <http://trac.webkit.org/changeset/117245>