Bug 84375 – [Chromium] Tooltip issue with visually contiguous elements having the same `title` attribute

• Status: RESOLVED
• Resolution: INVALID
• Component: Platform

[Shezan Baig]

Webkit behaves oddly when visually contiguous elements have the same value for the `title` attribute. As soon as you start hovering one of them, the title tooltip won’t move as you move to another element. Needless to say, this can be very annoying. Quick test case at http://jsbin.com/omahe3

This is to track the Chromium fix for bug 43112.  Patch will follow shortly

[Shezan Baig]

Created attachment 137974 [details]
Patch

for review

[Shezan Baig]

CC Adam for review

[Shezan Baig]

CC Darin (Adam is away)

[Shezan Baig]

Created attachment 139505 [details]
Patch (without dangling pointer)

remove the dangling pointer issue from the first patch. Instead of keeping a pointer to the hold, this patch keeps the rect of the node

[Shezan Baig]

correction: instead of keeping a pointer to the *node*, this patch keeps the rect of the node

[Eric Seidel (no email)]

Seems very odd to be keeping this extra state on ChromeClient. :(  But I'm not the right reviewer for this patch.

[Shezan Baig]

I saw your name in the svn blame of setToolTip, although that was from the initial checkin at rev 50741 ;)

Maybe WebViewImpl is a better place to keep this state?  I tried to avoid affecting cross-platform code for this though, but maybe I should just remove this bug and make a cross-platform change in bug 43112

[Eric Seidel (no email)]

Presumably that's from when the commit-queue was running under my account.  You should look at the ChangeLog to find who wrote the actual patch. :)

[Shezan Baig]

I'll make this change in bug 43112 for all platforms