Bug 84375 - [Chromium] Tooltip issue with visually contiguous elements having the same `title` attribute
Summary: [Chromium] Tooltip issue with visually contiguous elements having the same `t...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shezan Baig
URL: http://jsbin.com/omahe3
Keywords:
Depends on:
Blocks: 43112
  Show dependency treegraph
 
Reported: 2012-04-19 13:18 PDT by Shezan Baig
Modified: 2012-05-18 09:39 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.72 KB, patch)
2012-04-19 14:23 PDT, Shezan Baig
no flags Details | Formatted Diff | Diff
Patch (without dangling pointer) (4.40 KB, patch)
2012-04-30 13:19 PDT, Shezan Baig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shezan Baig 2012-04-19 13:18:49 PDT
Webkit behaves oddly when visually contiguous elements have the same value for the `title` attribute. As soon as you start hovering one of them, the title tooltip won’t move as you move to another element. Needless to say, this can be very annoying. Quick test case at http://jsbin.com/omahe3

This is to track the Chromium fix for bug 43112.  Patch will follow shortly
Comment 1 Shezan Baig 2012-04-19 14:23:34 PDT
Created attachment 137974 [details]
Patch

for review
Comment 2 Shezan Baig 2012-04-19 14:26:42 PDT
CC Adam for review
Comment 3 Shezan Baig 2012-04-19 14:28:33 PDT
CC Darin (Adam is away)
Comment 4 Shezan Baig 2012-04-30 13:19:42 PDT
Created attachment 139505 [details]
Patch (without dangling pointer)

remove the dangling pointer issue from the first patch. Instead of keeping a pointer to the hold, this patch keeps the rect of the node
Comment 5 Shezan Baig 2012-04-30 13:27:09 PDT
correction: instead of keeping a pointer to the *node*, this patch keeps the rect of the node
Comment 6 Eric Seidel (no email) 2012-05-07 15:09:12 PDT
Seems very odd to be keeping this extra state on ChromeClient. :(  But I'm not the right reviewer for this patch.
Comment 7 Shezan Baig 2012-05-07 15:20:17 PDT
I saw your name in the svn blame of setToolTip, although that was from the initial checkin at rev 50741 ;)

Maybe WebViewImpl is a better place to keep this state?  I tried to avoid affecting cross-platform code for this though, but maybe I should just remove this bug and make a cross-platform change in bug 43112
Comment 8 Eric Seidel (no email) 2012-05-07 15:23:51 PDT
Presumably that's from when the commit-queue was running under my account.  You should look at the ChangeLog to find who wrote the actual patch. :)
Comment 9 Shezan Baig 2012-05-18 09:39:39 PDT
I'll make this change in bug 43112 for all platforms