Bug 84162 – media-exit-fullscreen-button (and related enums) is unnecessary and should be removed.

• Status: REOPENED
• Component: Media

[Jer Noble]

media-exit-fullscreen-button (and related enums) is unnecessary and should be removed.

[Jer Noble]

That keyword was added in http://trac.webkit.org/changeset/111041 for (bug #70437).  The state of the full screen button does not need to be reflected in CSS.

[Jer Noble]

Created attachment 137580 [details]
Patch

[WebKit Review Bot]

Comment on attachment 137580 [details]
Patch

Rejecting attachment 137580 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
y/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 113] No route to host>

Full output: http://queues.webkit.org/results/12476285

[Jer Noble]

Committed r114789: <http://trac.webkit.org/changeset/114789>

[Jer Noble]

Rolled out commit in r114804.

Committed r114804: <http://trac.webkit.org/changeset/114804>

[Jer Noble]

Reopening after rollout.

[Ahmad Saleem]

I didn't manage to find anything with this 'media-exit-fullscreen-button' except some tests in CSSOM and 'js' file for Developer Tools.

I think we don't have these anymore and we can close this bug.

CCing - Eric, Dana and Jer Noble.