Bug 84094 - [MutationObservers] enable V8RecursionScope debug ASSERT()
Summary: [MutationObservers] enable V8RecursionScope debug ASSERT()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rafael Weinstein
URL:
Keywords:
Depends on:
Blocks: 68729
  Show dependency treegraph
 
Reported: 2012-04-16 16:20 PDT by Rafael Weinstein
Modified: 2012-04-17 16:03 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.43 KB, patch)
2012-04-16 16:26 PDT, Rafael Weinstein
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Weinstein 2012-04-16 16:20:39 PDT
This will cause a failure in chromium debug tests if any new usage of script invocation to a context initialized in WebKit.cpp is added without either going through V8Proxy or whitelisting the call as "internal" by allocating a V8RecusionScope::MicrotaskSuppression
Comment 1 Rafael Weinstein 2012-04-16 16:26:44 PDT
Created attachment 137424 [details]
Patch
Comment 2 Rafael Weinstein 2012-04-16 16:28:14 PDT
This will wait on (at least) https://chromiumcodereview.appspot.com/9969191/
Comment 3 Rafael Weinstein 2012-04-17 15:45:48 PDT
Chromium patch has landed and try job for this patch has cleared. I'd like to land this now.
Comment 4 Ryosuke Niwa 2012-04-17 15:49:38 PDT
Great change!
Comment 5 WebKit Review Bot 2012-04-17 16:03:02 PDT
Comment on attachment 137424 [details]
Patch

Clearing flags on attachment: 137424

Committed r114458: <http://trac.webkit.org/changeset/114458>
Comment 6 WebKit Review Bot 2012-04-17 16:03:15 PDT
All reviewed patches have been landed.  Closing bug.