Bug 84093 – Add support for MessagePortArray type to JSC

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Greg Billock]

See https://bugs.webkit.org/show_bug.cgi?id=83943 for V8 implementation.

[Chris Dumez]

This blocks WebIntents support for EFL port since the code added in r117384 (Web Intents Delivery) does not compile without this generator fix and there is no way to disable the Web Intents Delivery code at compile time.

[Chris Dumez]

A similar fix to the one made to the V8 engine in Bug 81127 is also needed for the new Web Intents Delivery code to compile.

[Chris Dumez]

Created attachment 143009 [details]
Patch

[Chris Dumez]

Created attachment 143010 [details]
Diff for Tools/Scripts/run-bindings-tests --reset-results

[Chris Dumez]

Created attachment 143011 [details]
stdout output for Tools/Scripts/run-bindings-tests --reset-results

[Chris Dumez]

Note that I had to make the following fix as well in order for the new Web Intents Delivery code to compile:
- return "SerializedScriptValue::create(exec, $value)";
+ return "SerializedScriptValue::create(exec, $value, 0, 0)";

This is because this function does not exist anymore:
static PassRefPtr<SerializedScriptValue> create(JSC::ExecState*, JSC::JSValue, SerializationErrorMode = Throwing);

It has been changed a while ago to:
static PassRefPtr<SerializedScriptValue> create(JSC::ExecState*, JSC::JSValue, MessagePortArray*, ArrayBufferArray*, SerializationErrorMode = Throwing);

I believe Bug 70186 added the MessagePortArray* argument.

I probably should file a second bug for this one line fix? Just say the word and I'll do that.

[Early Warning System Bot]

Comment on attachment 143009 [details]
Patch

Attachment 143009 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12747030

[Csaba Osztrogonác]

(In reply to comment #7)
> (From update of attachment 143009 [details])
> Attachment 143009 [details] did not pass qt-wk2-ews (qt):
> Output: http://queues.webkit.org/results/12747030

Sorry, it was false positive alarm.

[Chris Dumez]

Comment on attachment 143009 [details]
Patch

Restoring cq? flag since the ews warning was a false positive.

[Early Warning System Bot]

Comment on attachment 143009 [details]
Patch

Attachment 143009 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12738416

[Adam Barth]

Comment on attachment 143009 [details]
Patch

Ok.  Please run-bindings-tests with --reset-results before landing so that the updated results are committed with your change.

[Chris Dumez]

Created attachment 143045 [details]
Patch for landing

Include result from "Tools/Scripts/run-bindings-tests --reset-results" in the patch and update the Changelog accordingly.

[WebKit Review Bot]

Comment on attachment 143045 [details]
Patch for landing

Clearing flags on attachment: 143045

Committed r117795: <http://trac.webkit.org/changeset/117795>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.