Bug 70186 - Pass MessagePortArray to JSC's SerializedScriptValue::serialize/deserialize
Summary: Pass MessagePortArray to JSC's SerializedScriptValue::serialize/deserialize
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dmitry Lomov
URL:
Keywords:
Depends on:
Blocks: 65209
  Show dependency tree / graph
 
Reported: 2011-10-15 16:17 PDT by Dmitry Lomov
Modified: 2011-10-16 12:18 PDT (History)
4 users (show)

See Also:

Attachments
Fix (16.74 KB, patch)
2011-10-15 16:20 PDT, Dmitry Lomov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Lomov 2011-10-15 16:17:32 PDT 
SerializedScriptValue needs to know the message ports being sent with the message to implement trasfer
Comment 1 Dmitry Lomov 2011-10-15 16:20:15 PDT 
Created attachment 111154 [details]
Fix
Comment 2 David Levin 2011-10-15 19:27:47 PDT 
At first glance this seems fine. I'll look more and see if I notice anything that doesn't seem straightforward.

Adding Oliver in case he wants to look it over since he implemented SeriazlizedScriptValue for JSC and is familiar with JSC.
Comment 3 Oliver Hunt 2011-10-16 11:13:41 PDT 
Comment on attachment 111154 [details]
Fix

Looks sensible to me
Comment 4 WebKit Review Bot 2011-10-16 12:18:52 PDT 
Comment on attachment 111154 [details]
Fix

Clearing flags on attachment: 111154

Committed r97576: <http://trac.webkit.org/changeset/97576>
Comment 5 WebKit Review Bot 2011-10-16 12:18:56 PDT 
All reviewed patches have been landed.  Closing bug.