Bug 83859 – LocalizedDateICU should ignore timezones

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

LocalizedDateICU should ignore timezones

[Kent Tamura]

Created attachment 137038 [details]
Patch

[Kent Tamura]

This is a root cause of fast/forms/date-input-visible-string.html failure.


http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fforms%2Fdate%2Fdate-input-visible-string

[Hajime Morrita]

Comment on attachment 137038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137038&action=review

Looks good.  Picked a few nits.

> Source/WebCore/platform/text/LocalizedDateICU.cpp:48
> +    const UChar gmtTimezone[3] = {'G', 'M', 'T'};

Don't we need L prefix for each char?

> Source/WebCore/platform/text/LocalizedDateICU.cpp:50
> +    return udat_open(UDAT_NONE, UDAT_SHORT, defaultLanguage().utf8().data(), gmtTimezone, 3, 0, -1, &status);

We could use WTF_ARRAY_LENGTH?

[Kent Tamura]

Thanks.

(In reply to comment #3)
> > Source/WebCore/platform/text/LocalizedDateICU.cpp:48
> > +    const UChar gmtTimezone[3] = {'G', 'M', 'T'};
> 
> Don't we need L prefix for each char?

No.  UChar is not always wchar_t.

> > Source/WebCore/platform/text/LocalizedDateICU.cpp:50
> > +    return udat_open(UDAT_NONE, UDAT_SHORT, defaultLanguage().utf8().data(), gmtTimezone, 3, 0, -1, &status);
> 
> We could use WTF_ARRAY_LENGTH?

Yes.  will do.

[Kent Tamura]

Committed r114085: <http://trac.webkit.org/changeset/114085>