Bug 83815 - REGRESSION(112745) [CSS Filters] Memory use explosion for offscreen filtered elements
Summary: REGRESSION(112745) [CSS Filters] Memory use explosion for offscreen filtered ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandru Chiculita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-12 13:33 PDT by Alexandru Chiculita
Modified: 2012-04-12 16:55 PDT (History)
3 users (show)

See Also:


Attachments
Test case (502 bytes, text/html)
2012-04-12 14:09 PDT, Alexandru Chiculita
no flags Details
testcase with offscreen elements with grayscale filter (536 bytes, text/html)
2012-04-12 14:19 PDT, James Robinson
no flags Details
Patch V1 (6.22 KB, patch)
2012-04-12 15:08 PDT, Alexandru Chiculita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2012-04-12 13:33:01 PDT
In https://bugs.webkit.org/show_bug.cgi?id=80323 I fixed the drop-shadow and blur repainting issues by using the whole image of the layer and not just the dirty rectangle. That seems to introduce a memory regression on some sites.

In this patch I will disable the previous fix until we have a proper fix for https://bugs.webkit.org/show_bug.cgi?id=81263.
Comment 1 Alexandru Chiculita 2012-04-12 14:09:29 PDT
Created attachment 136969 [details]
Test case
Comment 2 James Robinson 2012-04-12 14:19:50 PDT
Created attachment 136971 [details]
testcase with offscreen elements with grayscale filter
Comment 3 Alexandru Chiculita 2012-04-12 15:08:42 PDT
Created attachment 136981 [details]
Patch V1
Comment 4 James Robinson 2012-04-12 15:27:04 PDT
Comment on attachment 136981 [details]
Patch V1

View in context: https://bugs.webkit.org/attachment.cgi?id=136981&action=review

> LayoutTests/css3/filters/offscreen-filters-memory-usage-expected.txt:1
> +This test passes if memory usage is not so hight that it crashes the browser. It should be less than 100MB.

typo: high
Comment 5 WebKit Review Bot 2012-04-12 16:55:44 PDT
Comment on attachment 136981 [details]
Patch V1

Clearing flags on attachment: 136981

Committed r114046: <http://trac.webkit.org/changeset/114046>
Comment 6 WebKit Review Bot 2012-04-12 16:55:48 PDT
All reviewed patches have been landed.  Closing bug.