This change extracts NetworkRequest from the Resource. It is now clear that these two should have super class that would be responsible for parsing URL and would define the requestContent signature. Corresponding patch will follow.
See https://bugs.webkit.org/show_bug.cgi?id=61363 for the meta bug.
Created attachment 136950 [details] Patch
What is the motivation for this change?
(In reply to comment #3) > What is the motivation for this change? I posted more details in https://bugs.webkit.org/show_bug.cgi?id=61363#c2.
Comment on attachment 136950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136950&action=review > Source/WebCore/inspector/front-end/RawSourceCode.js:57 > + if (this._request) Is it possible that both request and resource exist? If yes, it should be "this._request && !this._resource". > Source/WebCore/inspector/front-end/RawSourceCode.js:138 > + if (!this._request || !this._hasNewScripts) It should probably be !this._resource.
(In reply to comment #5) > (From update of attachment 136950 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=136950&action=review > > > Source/WebCore/inspector/front-end/RawSourceCode.js:57 > > + if (this._request) > > Is it possible that both request and resource exist? If yes, it should be "this._request && !this._resource". > No, it is not possible. > > Source/WebCore/inspector/front-end/RawSourceCode.js:138 > > + if (!this._request || !this._hasNewScripts) > > It should probably be !this._resource. This is ex-useTemporaryContent, so it is based on request, not resource.
Comment on attachment 136950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136950&action=review >> Source/WebCore/inspector/front-end/RawSourceCode.js:57 >> + if (this._request) > > Is it possible that both request and resource exist? If yes, it should be "this._request && !this._resource". Let's rename it to _pendingRequest > Source/WebCore/inspector/front-end/ResourceScriptMapping.js:99 > + if (request && (request.finished || request.type !== WebInspector.resourceTypes.Document)) request.finished check seems redundant for inflights.
Committed r114116: <http://trac.webkit.org/changeset/114116>