WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
61363
Web Inspector: [META] extract WebInspector.NetworkRequest (NetworkPanel item) from WebInspector.Resource (ResourcesPanel item).
https://bugs.webkit.org/show_bug.cgi?id=61363
Summary
Web Inspector: [META] extract WebInspector.NetworkRequest (NetworkPanel item)...
Vsevolod Vlasov
Reported
2011-05-24 08:17:42 PDT
Separate NetworkResource (NetworkPanel resource) from ResourceRevision (ResourcesPanel/ScriptsPanel resource).
Attachments
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2012-04-10 11:22:16 PDT
I performed this refactoring locally, but it resulted in a huge patch. I extracted NetworkRequest from Resource and aggregated it in the resource as a request field for now. I intend to land it in [at least] two phases: 1) Introduce empty WebInspector.NetworkRequest and temporarily inherit it from WebInspector.Resource. Creating WebInspector.Resource on top of the request item just returns the request itself from the constructor. Modify all call sites to treat requests as such. 2) Extract actual methods from Resource and move them into the NetworkRequest. Fetching content will need special handling here.
Pavel Feldman
Comment 2
2012-04-12 13:02:58 PDT
Few words on the motivation for this change: Today we are using the same class "WebInspector.Resource" both as a workspace resource and a network resource. Splitting it into two entities would allow us to better structure the front-end code: Network panel, Audits, Extensions would operate WebInspector.NetworkRequest. It will be based on the "network" protocol domain and will be self-contained and separable. WebInspector.Resource would become a model element (document) for the Resources Panel and potentially more workspace-centric perspectives. Present Resource is handling both: workspace and the network purposes which makes its interface overloaded with random functions.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug