RESOLVED FIXED Bug 83773
Web Inspector: extracting NetworkRequest from Resource (step 2) 
https://bugs.webkit.org/show_bug.cgi?id=83773
Summary Web Inspector: extracting NetworkRequest from Resource (step 2)
Pavel Feldman
Reported 2012-04-12 05:20:02 PDT
This step moves request-related views from being resource-based to request-based. See https://bugs.webkit.org/show_bug.cgi?id=61363 for the meta bug.
Attachments
Patch (124.45 KB, patch)
2012-04-12 05:54 PDT, Pavel Feldman 		yurys: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-04-12 05:54:52 PDT
Created attachment 136886 [details] Patch
Yury Semikhatsky
Comment 2 2012-04-12 06:02:35 PDT
Comment on attachment 136886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136886&action=review > Source/WebCore/inspector/front-end/Resource.js:168 > + request: function() Could you do rename and modifications like this in separate patches please, otherwise it is impossible to say if it breaks anything as the change size grows to more than 100Kb?
Early Warning System Bot
Comment 3 2012-04-12 06:04:29 PDT
Comment on attachment 136886 [details] Patch Attachment 136886 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12390410
Pavel Feldman
Comment 4 2012-04-12 06:06:15 PDT
(In reply to comment #2) > (From update of attachment 136886 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=136886&action=review > > > Source/WebCore/inspector/front-end/Resource.js:168 > > + request: function() > > Could you do rename and modifications like this in separate patches please, otherwise it is impossible to say if it breaks anything as the change size grows to more than 100Kb? Reverted this change, sorry about that. I was splitting a larger patch, so it squeezed in.
Pavel Feldman
Comment 5 2012-04-12 06:13:07 PDT
Committed r113966: <http://trac.webkit.org/changeset/113966>
Note You need to log in before you can comment on or make changes to this bug.