Bug 83773 - Web Inspector: extracting NetworkRequest from Resource (step 2)
Summary: Web Inspector: extracting NetworkRequest from Resource (step 2)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-12 05:20 PDT by Pavel Feldman
Modified: 2012-04-12 06:13 PDT (History)
10 users (show)

See Also:

Attachments
Patch (124.45 KB, patch)
2012-04-12 05:54 PDT, Pavel Feldman 		yurys: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-04-12 05:20:02 PDT 
This step moves request-related views from being resource-based to request-based.
See https://bugs.webkit.org/show_bug.cgi?id=61363 for the meta bug.
Comment 1 Pavel Feldman 2012-04-12 05:54:52 PDT 
Created attachment 136886 [details]
Patch
Comment 2 Yury Semikhatsky 2012-04-12 06:02:35 PDT 
Comment on attachment 136886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136886&action=review

> Source/WebCore/inspector/front-end/Resource.js:168
> +    request: function()

Could you do rename and modifications like this in separate patches please, otherwise it is impossible to say if it breaks anything as the change size grows to more than 100Kb?
Comment 3 Early Warning System Bot 2012-04-12 06:04:29 PDT 
Comment on attachment 136886 [details]
Patch

Attachment 136886 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12390410
Comment 4 Pavel Feldman 2012-04-12 06:06:15 PDT 
(In reply to comment #2)
> (From update of attachment 136886 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=136886&action=review
> 
> > Source/WebCore/inspector/front-end/Resource.js:168
> > +    request: function()
> 
> Could you do rename and modifications like this in separate patches please, otherwise it is impossible to say if it breaks anything as the change size grows to more than 100Kb?

Reverted this change, sorry about that. I was splitting a larger patch, so it squeezed in.
Comment 5 Pavel Feldman 2012-04-12 06:13:07 PDT 
Committed r113966: <http://trac.webkit.org/changeset/113966>