Bug 83761 - [Chromium] Enable INPUT_TYPE_DATE
Summary: [Chromium] Enable INPUT_TYPE_DATE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: HTML5Forms 83852
  Show dependency treegraph
 
Reported: 2012-04-12 02:08 PDT by Kent Tamura
Modified: 2012-04-12 19:04 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.10 KB, patch)
2012-04-12 02:23 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-04-12 02:08:11 PDT
[Chromium] Enable INPUT_TYPE_DATE
Comment 1 Kent Tamura 2012-04-12 02:23:45 PDT
Created attachment 136858 [details]
Patch
Comment 2 Kentaro Hara 2012-04-12 03:05:22 PDT
Comment on attachment 136858 [details]
Patch

Wouldn't there be any concern about enabling INPUT_TYPE_DATE? (I am not familiar with the consensus.)
Comment 3 Peter Beverloo 2012-04-12 03:10:22 PDT
I can imagine that quite some code (rendering/JavaScript/CSS as well) is going to be shared for the different date and time UIs, wouldn't it be better to wait for it to mature a bit?

Is there a run-time flag for the functionality? Input types such as "date" and "month"/"week" are rather similar, it may confuse web developers when certain types work, but others don't.
Comment 4 Kent Tamura 2012-04-12 03:22:25 PDT
H> Wouldn't there be any concern about enabling INPUT_TYPE_DATE? (I am not familiar with the consensus.)

P> I can imagine that quite some code (rendering/JavaScript/CSS as well) is going to be shared for the different date and time UIs, wouldn't it be better to wait for it to mature a bit?

P> Is there a run-time flag for the functionality? Input types such as "date" and "month"/"week" are rather similar, it may confuse web developers when certain types work, but others don't.

I don't think we should enable all the types at once.  I'd like to ship available types one by one.  We need some months to implement other date/time types.

The date type still have small UI issues.  I'd like to enable it now and have feedbacks.  If we couldn't make it mature before M20 branch, I'll introduce a runtime flag and disable it by default. 

Issues:
* RTL: Bug 83668
* No keyboard-binding to open a calendar picker
* default placeholder to indicate the format
Comment 5 Kentaro Hara 2012-04-12 03:41:57 PDT
Comment on attachment 136858 [details]
Patch

rs=me based on tkent's comment.
Comment 6 WebKit Review Bot 2012-04-12 07:22:09 PDT
Comment on attachment 136858 [details]
Patch

Clearing flags on attachment: 136858

Committed r113972: <http://trac.webkit.org/changeset/113972>
Comment 7 WebKit Review Bot 2012-04-12 07:22:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Kent Tamura 2012-04-12 18:35:13 PDT
Anyway I'll introduce a runtime flag to disable this easily.