Bug 83590 - Update cmakeconfig.h.in after r113570
Summary: Update cmakeconfig.h.in after r113570
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 72815
Blocks:
  Show dependency tree / graph
 
Reported: 2012-04-10 10:03 PDT by Patrick R. Gansterer
Modified: 2015-02-26 07:08 PST (History)
8 users (show)

See Also:

Attachments
Patch (4.16 KB, patch)
2012-04-10 10:05 PDT, Patrick R. Gansterer 		gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Patch (4.19 KB, patch)
2012-04-10 10:29 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (4.15 KB, patch)
2012-04-10 10:32 PDT, Patrick R. Gansterer 		rwlbuis: review+
dbates: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-04-10 10:03:05 PDT 
Update cmakeconfig.h.in after r113570
Comment 1 Patrick R. Gansterer 2012-04-10 10:05:55 PDT 
Created attachment 136477 [details]
Patch
Comment 2 Daniel Bates 2012-04-10 10:24:06 PDT 
Comment on attachment 136477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136477&action=review

> Source/cmakeconfig.h.cmake:-21
> -#cmakedefine01 ENABLE_DRT

This is used by the BlackBerry port.

> Source/cmakeconfig.h.cmake:-65
> -#cmakedefine01 ENABLE_VIEWPORT_REFLOW

Ditto.
Comment 3 Patrick R. Gansterer 2012-04-10 10:29:22 PDT 
Created attachment 136485 [details]
Patch
Comment 4 Patrick R. Gansterer 2012-04-10 10:30:17 PDT 
(In reply to comment #2)
> (From update of attachment 136477 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=136477&action=review
> 
> > Source/cmakeconfig.h.cmake:-21
> > -#cmakedefine01 ENABLE_DRT
> 
> This is used by the BlackBerry port.
> 
> > Source/cmakeconfig.h.cmake:-65
> > -#cmakedefine01 ENABLE_VIEWPORT_REFLOW
> 
> Ditto.

Sorry, missed the Blackberry specific ones. Fixed now.
Comment 5 Patrick R. Gansterer 2012-04-10 10:32:36 PDT 
Created attachment 136486 [details]
Patch
Comment 6 Rob Buis 2012-04-10 10:35:45 PDT 
Comment on attachment 136477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136477&action=review

> Source/cmakeconfig.h.cmake:-26
> -#cmakedefine01 ENABLE_FIXED_REPORTED_SIZE

This is also used by the BlackBerry port.

> Source/cmakeconfig.h.cmake:-53
> -#cmakedefine01 ENABLE_OVERFLOW_SCROLLING

Ditto.
Comment 7 Daniel Bates 2012-04-10 10:36:23 PDT 
Comment on attachment 136486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136486&action=review

> Source/cmakeconfig.h.cmake:-15
> -#cmakedefine01 ENABLE_CLIENT_BASED_GEOLOCATION

According to <https://bugs.webkit.org/show_bug.cgi?id=82594#c4> this is still used by the BlackBerry port.

> Source/cmakeconfig.h.cmake:-26
> -#cmakedefine01 ENABLE_FIXED_REPORTED_SIZE

This is used by the BlackBerry port. (Added in changeset 112654; <http://trac.webkit.org/changeset/112654/trunk/Source/cmakeconfig.h.cmake>)

> Source/cmakeconfig.h.cmake:-53
> -#cmakedefine01 ENABLE_OVERFLOW_SCROLLING

Ditto.
Comment 8 Rob Buis 2012-04-10 10:36:38 PDT 
Comment on attachment 136486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136486&action=review

> Source/cmakeconfig.h.cmake:-26
> -#cmakedefine01 ENABLE_FIXED_REPORTED_SIZE

This is used by the BlackBerry port.

> Source/cmakeconfig.h.cmake:-53
> -#cmakedefine01 ENABLE_OVERFLOW_SCROLLING

Ditto.
Comment 9 Rob Buis 2012-04-10 10:39:38 PDT 
Comment on attachment 136486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136486&action=review

>>> Source/cmakeconfig.h.cmake:-26
>>> -#cmakedefine01 ENABLE_FIXED_REPORTED_SIZE
>> 
>> This is used by the BlackBerry port.
> 
> This is used by the BlackBerry port. (Added in changeset 112654; <http://trac.webkit.org/changeset/112654/trunk/Source/cmakeconfig.h.cmake>)

This is used by the BlackBerry port.

>>> Source/cmakeconfig.h.cmake:-53
>>> -#cmakedefine01 ENABLE_OVERFLOW_SCROLLING
>> 
>> Ditto.
> 
> Ditto.

Ditto.
Comment 10 Patrick R. Gansterer 2012-04-10 10:41:34 PDT 
hmm, i grep'ed the features i removed:
e.g "grep -r ENABLE\(CLIENT_BASED ." does not give any results (expect ChangeLog ;-)) in the Source directory.
Is there a way how i can check the needed features?
Comment 11 Patrick R. Gansterer 2012-04-10 10:45:48 PDT 
What about adding them again, when needed?
E.g. CLIENT_BASED_GEOLOCATION has been removed in http://trac.webkit.org/changeset/110595, so you need to change your not upstreamed files anyway to match trunk?
Comment 12 Rob Buis 2012-04-10 10:47:10 PDT 
Hi Patrick,

(In reply to comment #11)
> What about adding them again, when needed?
> E.g. CLIENT_BASED_GEOLOCATION has been removed in http://trac.webkit.org/changeset/110595, so you need to change your not upstreamed files anyway to match trunk?

Jeff Rogers replied on the thread in webkit-dev, you can remove CLIENT_BASED_GEOLOCATION define from BlackBerry point of view.
Comment 13 Gyuyoung Kim 2012-04-10 11:17:04 PDT 
Comment on attachment 136477 [details]
Patch

Attachment 136477 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12344031
Comment 14 Gyuyoung Kim 2012-04-10 12:25:19 PDT 
Comment on attachment 136486 [details]
Patch

Attachment 136486 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12379574
Comment 15 Csaba Osztrogonác 2015-02-26 07:08:12 PST 
It is invalid long long time ago.