Bug 83590 – Update cmakeconfig.h.in after r113570

• Status: RESOLVED
• Resolution: INVALID
• Component: Tools / Tests

[Patrick R. Gansterer]

Update cmakeconfig.h.in after r113570

[Patrick R. Gansterer]

Created attachment 136477 [details]
Patch

[Daniel Bates]

Comment on attachment 136477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136477&action=review

> Source/cmakeconfig.h.cmake:-21
> -#cmakedefine01 ENABLE_DRT

This is used by the BlackBerry port.

> Source/cmakeconfig.h.cmake:-65
> -#cmakedefine01 ENABLE_VIEWPORT_REFLOW

Ditto.

[Patrick R. Gansterer]

Created attachment 136485 [details]
Patch

[Patrick R. Gansterer]

(In reply to comment #2)
> (From update of attachment 136477 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=136477&action=review
> 
> > Source/cmakeconfig.h.cmake:-21
> > -#cmakedefine01 ENABLE_DRT
> 
> This is used by the BlackBerry port.
> 
> > Source/cmakeconfig.h.cmake:-65
> > -#cmakedefine01 ENABLE_VIEWPORT_REFLOW
> 
> Ditto.

Sorry, missed the Blackberry specific ones. Fixed now.

[Patrick R. Gansterer]

Created attachment 136486 [details]
Patch

[Rob Buis]

Comment on attachment 136477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136477&action=review

> Source/cmakeconfig.h.cmake:-26
> -#cmakedefine01 ENABLE_FIXED_REPORTED_SIZE

This is also used by the BlackBerry port.

> Source/cmakeconfig.h.cmake:-53
> -#cmakedefine01 ENABLE_OVERFLOW_SCROLLING

Ditto.

[Daniel Bates]

Comment on attachment 136486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136486&action=review

> Source/cmakeconfig.h.cmake:-15
> -#cmakedefine01 ENABLE_CLIENT_BASED_GEOLOCATION

According to <https://bugs.webkit.org/show_bug.cgi?id=82594#c4> this is still used by the BlackBerry port.

> Source/cmakeconfig.h.cmake:-26
> -#cmakedefine01 ENABLE_FIXED_REPORTED_SIZE

This is used by the BlackBerry port. (Added in changeset 112654; <http://trac.webkit.org/changeset/112654/trunk/Source/cmakeconfig.h.cmake>)

> Source/cmakeconfig.h.cmake:-53
> -#cmakedefine01 ENABLE_OVERFLOW_SCROLLING

Ditto.

[Rob Buis]

Comment on attachment 136486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136486&action=review

> Source/cmakeconfig.h.cmake:-26
> -#cmakedefine01 ENABLE_FIXED_REPORTED_SIZE

This is used by the BlackBerry port.

> Source/cmakeconfig.h.cmake:-53
> -#cmakedefine01 ENABLE_OVERFLOW_SCROLLING

Ditto.

[Rob Buis]

Comment on attachment 136486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136486&action=review

>>> Source/cmakeconfig.h.cmake:-26
>>> -#cmakedefine01 ENABLE_FIXED_REPORTED_SIZE
>> 
>> This is used by the BlackBerry port.
> 
> This is used by the BlackBerry port. (Added in changeset 112654; <http://trac.webkit.org/changeset/112654/trunk/Source/cmakeconfig.h.cmake>)

This is used by the BlackBerry port.

>>> Source/cmakeconfig.h.cmake:-53
>>> -#cmakedefine01 ENABLE_OVERFLOW_SCROLLING
>> 
>> Ditto.
> 
> Ditto.

Ditto.

[Patrick R. Gansterer]

hmm, i grep'ed the features i removed:
e.g "grep -r ENABLE\(CLIENT_BASED ." does not give any results (expect ChangeLog ;-)) in the Source directory.
Is there a way how i can check the needed features?

[Patrick R. Gansterer]

What about adding them again, when needed?
E.g. CLIENT_BASED_GEOLOCATION has been removed in http://trac.webkit.org/changeset/110595, so you need to change your not upstreamed files anyway to match trunk?

[Rob Buis]

Hi Patrick,

(In reply to comment #11)
> What about adding them again, when needed?
> E.g. CLIENT_BASED_GEOLOCATION has been removed in http://trac.webkit.org/changeset/110595, so you need to change your not upstreamed files anyway to match trunk?

Jeff Rogers replied on the thread in webkit-dev, you can remove CLIENT_BASED_GEOLOCATION define from BlackBerry point of view.

[Gyuyoung Kim]

Comment on attachment 136477 [details]
Patch

Attachment 136477 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12344031

[Gyuyoung Kim]

Comment on attachment 136486 [details]
Patch

Attachment 136486 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12379574

[Csaba Osztrogonác]

It is invalid long long time ago.