RESOLVED FIXED 82594
[BlackBerry] Add more ENABLERS to cmakeconfig.h.cmake 
https://bugs.webkit.org/show_bug.cgi?id=82594
Summary [BlackBerry] Add more ENABLERS to cmakeconfig.h.cmake
Charles Wei
Reported 2012-03-29 03:45:06 PDT
BlackBerry porting uses much more features, which need to be put in this template file to be enabled.
Attachments
Add more enabler to cmake config template. (3.55 KB, patch)
2012-03-29 04:21 PDT, Charles Wei 		rwlbuis: review-
DetailsFormatted DiffDiff
Update the patch to add feature enablers for BlackBerry porting (5.45 KB, patch)
2012-03-29 23:48 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Charles Wei
Comment 1 2012-03-29 04:21:22 PDT
Created attachment 134543 [details] Add more enabler to cmake config template.
Rob Buis
Comment 2 2012-03-29 07:05:16 PDT
Comment on attachment 134543 [details] Add more enabler to cmake config template. View in context: https://bugs.webkit.org/attachment.cgi?id=134543&action=review HAve a good look if we really need all of these. > Source/cmakeconfig.h.cmake:15 > +#cmakedefine01 ENABLE_CLIENT_BASED_GEOLOCATION I dont think this exists anymore. > Source/cmakeconfig.h.cmake:16 > +#cmakedefine01 ENABLE_DATAGRID Ditto. > Source/cmakeconfig.h.cmake:32 > +#cmakedefine01 ENABLE_GROUP_BASED_DATABASE Ditto.
Charles Wei
Comment 3 2012-03-29 18:53:19 PDT
Internal : 147101
Charles Wei
Comment 4 2012-03-29 18:54:31 PDT
Comment on attachment 134543 [details] Add more enabler to cmake config template. View in context: https://bugs.webkit.org/attachment.cgi?id=134543&action=review >> Source/cmakeconfig.h.cmake:15 >> +#cmakedefine01 ENABLE_CLIENT_BASED_GEOLOCATION > > I dont think this exists anymore. This is still used by BlackBerry porting. >> Source/cmakeconfig.h.cmake:16 >> +#cmakedefine01 ENABLE_DATAGRID > > Ditto. Agree, need to be removed. >> Source/cmakeconfig.h.cmake:32 >> +#cmakedefine01 ENABLE_GROUP_BASED_DATABASE > > Ditto. Agree. Need to be removed.
Charles Wei
Comment 5 2012-03-29 23:48:36 PDT
Created attachment 134733 [details] Update the patch to add feature enablers for BlackBerry porting Add feature enablers in cmakeconfig.h.cmake needed by BlackBerry porting, and remove obsolete MACROs in OptionsBlackBerry.cmake.
Rob Buis
Comment 6 2012-03-30 04:24:16 PDT
Comment on attachment 134733 [details] Update the patch to add feature enablers for BlackBerry porting Looks good.
Charles Wei
Comment 7 2012-03-30 04:34:58 PDT
Comment on attachment 134733 [details] Update the patch to add feature enablers for BlackBerry porting Thanks for the review, Rob.
WebKit Review Bot
Comment 8 2012-03-30 05:27:54 PDT
Comment on attachment 134733 [details] Update the patch to add feature enablers for BlackBerry porting Clearing flags on attachment: 134733 Committed r112654: <http://trac.webkit.org/changeset/112654>
WebKit Review Bot
Comment 9 2012-03-30 05:27:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.