Bug 82594 - [BlackBerry] Add more ENABLERS to cmakeconfig.h.cmake
Summary: [BlackBerry] Add more ENABLERS to cmakeconfig.h.cmake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-29 03:45 PDT by Charles Wei
Modified: 2012-03-30 05:27 PDT (History)
5 users (show)

See Also:

Attachments
Add more enabler to cmake config template. (3.55 KB, patch)
2012-03-29 04:21 PDT, Charles Wei 		rwlbuis: review-
Details | Formatted Diff | Diff
Update the patch to add feature enablers for BlackBerry porting (5.45 KB, patch)
2012-03-29 23:48 PDT, Charles Wei 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2012-03-29 03:45:06 PDT 
BlackBerry porting uses much more features, which need to be put in this template file to be enabled.
Comment 1 Charles Wei 2012-03-29 04:21:22 PDT 
Created attachment 134543 [details]
Add more enabler to cmake config template.
Comment 2 Rob Buis 2012-03-29 07:05:16 PDT 
Comment on attachment 134543 [details]
Add more enabler to cmake config template.

View in context: https://bugs.webkit.org/attachment.cgi?id=134543&action=review

HAve a good look if we really need all of these.

> Source/cmakeconfig.h.cmake:15
> +#cmakedefine01 ENABLE_CLIENT_BASED_GEOLOCATION

I dont think this exists anymore.

> Source/cmakeconfig.h.cmake:16
> +#cmakedefine01 ENABLE_DATAGRID

Ditto.

> Source/cmakeconfig.h.cmake:32
> +#cmakedefine01 ENABLE_GROUP_BASED_DATABASE

Ditto.
Comment 3 Charles Wei 2012-03-29 18:53:19 PDT 
Internal : 147101
Comment 4 Charles Wei 2012-03-29 18:54:31 PDT 
Comment on attachment 134543 [details]
Add more enabler to cmake config template.

View in context: https://bugs.webkit.org/attachment.cgi?id=134543&action=review

>> Source/cmakeconfig.h.cmake:15
>> +#cmakedefine01 ENABLE_CLIENT_BASED_GEOLOCATION
> 
> I dont think this exists anymore.

This is still used by BlackBerry porting.

>> Source/cmakeconfig.h.cmake:16
>> +#cmakedefine01 ENABLE_DATAGRID
> 
> Ditto.

Agree, need to be removed.

>> Source/cmakeconfig.h.cmake:32
>> +#cmakedefine01 ENABLE_GROUP_BASED_DATABASE
> 
> Ditto.

Agree. Need to be removed.
Comment 5 Charles Wei 2012-03-29 23:48:36 PDT 
Created attachment 134733 [details]
Update the patch to add feature enablers for BlackBerry porting

Add feature enablers in cmakeconfig.h.cmake needed by BlackBerry porting,  and remove obsolete MACROs in OptionsBlackBerry.cmake.
Comment 6 Rob Buis 2012-03-30 04:24:16 PDT 
Comment on attachment 134733 [details]
Update the patch to add feature enablers for BlackBerry porting

Looks good.
Comment 7 Charles Wei 2012-03-30 04:34:58 PDT 
Comment on attachment 134733 [details]
Update the patch to add feature enablers for BlackBerry porting

Thanks for the review, Rob.
Comment 8 WebKit Review Bot 2012-03-30 05:27:54 PDT 
Comment on attachment 134733 [details]
Update the patch to add feature enablers for BlackBerry porting

Clearing flags on attachment: 134733

Committed r112654: <http://trac.webkit.org/changeset/112654>
Comment 9 WebKit Review Bot 2012-03-30 05:27:58 PDT 
All reviewed patches have been landed.  Closing bug.