[CMake] Use WEBKIT_CREATE_FORWARDING_HEADERS to generate WK2 forwarding headers
Created attachment 136453 [details]
CC'ing the Samsung guys who can test it with their working WebKit2-EFL.
Given the lack of feedback and the fact that webkit2-efl hasn't been fully upstreamed yet (IIRC), I think you can just go forward with it.
Sorry about late answer.
I did not catch this bug.
As kubo commented, more patches are needed to build webkit2-efl successfully.
So, I do not have objection for this.
But FYI, I have some build break of webkit2-efl in my local(email@example.com:bunhere/webkit-mirror.git webkit-efl-new branch).
Below is error message.
/home/ryuan/workspace/github/webkit-mirror/Source/WebKit2/Platform/CoreIPC/Connection.cpp:31:29: fatal error: WebCore/RunLoop.h: No such file or directory
[ 89%] [ 89%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/Shared/APIObject.cpp.o
Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/Shared/APIClientTraits.cpp.o
[ 89%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/Shared/ChildProcess.cpp.o
In file included from /home/ryuan/workspace/github/webkit-mirror/build/DerivedSources/ForwardingHeaders/WebKit2/WKBase.h:1:0,
/home/ryuan/workspace/github/webkit-mirror/Source/WebKit2/Shared/API/c/WKBase.h:41:31: fatal error: WebKit2/WKBaseEfl.h: No such file or directory
make: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/Shared/APIClientTraits.cpp.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from /home/ryuan/workspace/github/webkit-mirror/Source/WebKit2/Shared/ChildProcess.cpp:27:0:
/home/ryuan/workspace/github/webkit-mirror/Source/WebKit2/Shared/ChildProcess.h:30:29: fatal error: WebCore/RunLoop.h: No such file or directory
make: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/Platform/CoreIPC/Connection.cpp.o] Error 1
make: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/Shared/ChildProcess.cpp.o] Error 1
make: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/all] Error 2
make: *** [all] Error 2
I checked and fixed build break via http://pastebin.com/V5v3tA8R
Created attachment 155183 [details]
Comment on attachment 155183 [details]
Clearing flags on attachment: 155183
Committed r123983: <http://trac.webkit.org/changeset/123983>
All reviewed patches have been landed. Closing bug.
This patch broke the EFL build. It wasn't caught by the EWS because it would need a clean build to reproduce the breakage.
(In reply to comment #9)
> This patch broke the EFL build. It wasn't caught by the EWS because it would need a clean build to reproduce the breakage.
Would be great if you can post the error messages too, if you want someone to fix it. ;-)
(In reply to comment #10)
> (In reply to comment #9)
> > This patch broke the EFL build. It wasn't caught by the EWS because it would need a clean build to reproduce the breakage.
> Would be great if you can post the error messages too, if you want someone to fix it. ;-)
I'm fixing it.
Re-opened since this is blocked by 92663