Bug 83574 – [CMake] Add WEBKIT_CREATE_FORWARDING_HEADERS macro

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Patrick R. Gansterer]

[CMake] Add WEBKIT_CREATE_FORWARDING_HEADERS macro

[Patrick R. Gansterer]

Created attachment 136445 [details]
Patch

[Patrick R. Gansterer]

Comment on attachment 136445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136445&action=review

> ChangeLog:9
> +        It accepts a list of files and/or a list of directories as input.

See CMake based build system for WinApple at https://bugs.webkit.org/show_bug.cgi?id=72816 for usage.

[Daniel Bates]

Comment on attachment 136445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136445&action=review

> Source/cmake/WebKitMacros.cmake:192
> +    SET(_doing_directories 0)
> +    SET(_doing_files 0)

These names are OK as-as. Maybe the prefix "_processing_" would be somewhat more descriptive than the prefix "_doing_".  That being said, both "processing" and "doing" are somewhat vague terms.

> Source/cmake/WebKitMacros.cmake:198
> +        STRING(REGEX MATCH "^#include \"(.*)\"" _matched ${_content})

Can we make this regular expression stronger? In particular, would substituting [^"] instead of (.*) help strengthen this? Can we also match the newline/end-of-line character '$'?

[Daniel Bates]

(In reply to comment #3)
> > Source/cmake/WebKitMacros.cmake:198
> > +        STRING(REGEX MATCH "^#include \"(.*)\"" _matched ${_content})
> 
> Can we make this regular expression stronger? In particular, would substituting [^"] instead of (.*) help strengthen this? Can we also match the newline/end-of-line character '$'?

I meant ([^"]) instead of (.*).

[Patrick R. Gansterer]

Comment on attachment 136445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136445&action=review

>> Source/cmake/WebKitMacros.cmake:198
>> +        STRING(REGEX MATCH "^#include \"(.*)\"" _matched ${_content})
> 
> Can we make this regular expression stronger? In particular, would substituting [^"] instead of (.*) help strengthen this? Can we also match the newline/end-of-line character '$'?

i added the [^"], but newline matching isn't possible (at least on windows)

[Patrick R. Gansterer]

Committed r113844: <http://trac.webkit.org/changeset/113844>

[Thiago Marcos P. Santos]

I'm trying to understand: why using a CMake macro is better than using the existing script used by all platforms?