Bug 83354 – check-webkit-style should remind folks to update the results for run-bindings-tests

• Status: NEW
• Component: New Bugs

[Vineet Chaudhary (vineetc)]

This came up with https://bugs.webkit.org/show_bug.cgi?id=83233#c6.
It is observed that if changes are made in Codegenerator*.pm we need to rebase results of run-bindings-tests.
It should be mandate or atleast warn author to run run-bindings-tests if Codegenerator is modified.

IMO we should add check in ./check-webkit-style.

[Kentaro Hara]

(In reply to comment #0)
> This came up with https://bugs.webkit.org/show_bug.cgi?id=83233#c6.
> It is observed that if changes are made in Codegenerator*.pm we need to rebase results of run-bindings-tests.
> It should be mandate or atleast warn author to run run-bindings-tests if Codegenerator is modified.
> 
> IMO we should add check in ./check-webkit-style.

There had been several discussions on this topic; i.e. where run-bindings-tests should run.

run-bindings-tests are just for showing reviewers what changes the patch is going to make. Even if run-bindings-tests fail, it is not a serious problem. Thus, the build bots ignore the run-bindings-tests results. Consequently, people sometimes forget to update the results.

> It should be mandate or atleast warn author to run run-bindings-tests if Codegenerator is modified.

I think it is a good idea. Although we should avoid running run-bindings-tests per ./check-webkit-style, it is a good idea to have ./check-webkit-style warn that "You changed WebCore/bindings/scripts/. Did you update the run-bindings-tests results?", if any changes are found in WebCore/bindings/scripts/.

Since this is a topic that had been discussed in webkit-dev@, I would recommend that you discuss the suggestion in webkit-dev@.