You need to
before you can comment on or make changes to this bug.
Per the comment in FrameLoader::finishedLoadingDocument(), there's a lot of work FrameLoader is doing that it should be delegating. For that matter, FrameLoader::m_archive should really be hanging off the DocumentLoader, too.
Created an attachment (id=135389) [details]
(From update of attachment 135389 [details])
Attachment 135389 [details] did not pass gtk-ews (gtk):
Created an attachment (id=135414) [details]
fix gtk compile
(From update of attachment 135414 [details])
Attachment 135414 [details] did not pass chromium-ews (chromium-xvfb):
New failing tests:
Created an attachment (id=135437) [details]
Archive of layout-test-results from ec2-cr-linux-04
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created an attachment (id=135690) [details]
Fix mhtml test failure
(From update of attachment 135690 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=135690&action=review
This patch makes too much sense!
> void addAllArchiveResources(Archive*);
Can this be private now?
> + // Give archive machinery a crack at this document. If the MIME type is not an archive type, it will return 0.
Give archive machinery -> Give the archive machinery
(In reply to comment #7)
> (From update of attachment 135690 [details] [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135690&action=review
> This patch makes too much sense!
> > Source/WebCore/loader/DocumentLoader.h:136
> > void addAllArchiveResources(Archive*);
> Can this be private now?
Nope. I didn't deal with the usage in FrameLoader::loadArchive(), and I see usages in PasteboardMac and WebKit/mac's WebDataSource.
> > Source/WebCore/loader/DocumentLoader.cpp:453
> > + // Give archive machinery a crack at this document. If the MIME type is not an archive type, it will return 0.
> Give archive machinery -> Give the archive machinery
Created an attachment (id=136063) [details]
Patch for landing
(From update of attachment 136063 [details])
Clearing flags on attachment: 136063
Committed r113526: <http://trac.webkit.org/changeset/113526>
All reviewed patches have been landed. Closing bug.
This broke one of the Chrome browser_tests: RenderViewHostTest.BaseURLParam. I've rolled it back. Can you take a look when you get a chance?
Reopening since this was rolled out.
Created an attachment (id=136923) [details]
Move setBaseURLOverride call back to FrameLoader
It turns out that setBaseURLOverride() needs to be called as soon as possible after an MHTML Document is created, and there is currently no way to do that in DocumentLoader.
My next planned cleanup is in the relationship between DocumentLoader, DocumentWriter and FrameLoader, so I will deal with this soon.
Created an attachment (id=136935) [details]
Patch for landing
(From update of attachment 136935 [details])
Clearing flags on attachment: 136935
Committed r114016: <http://trac.webkit.org/changeset/114016>