Bug 83003 - Web Inspector: Database::Database::id field in the protocol should have type integer not string
Summary: Web Inspector: Database::Database::id field in the protocol should have type ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 23:36 PDT by Yury Semikhatsky
Modified: 2012-04-03 05:08 PDT (History)
14 users (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2012-04-02 23:39 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (24.37 KB, patch)
2012-04-03 02:51 PDT, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-04-02 23:36:46 PDT 
At the moment it is passed as int but declared as string. The declaration can be easily fixed as the message is still hidden. It was discovered while switching Database domain to the new typed API: https://bugs.webkit.org/show_bug.cgi?id=82958
Comment 1 Yury Semikhatsky 2012-04-02 23:39:20 PDT 
Created attachment 135279 [details]
Patch
Comment 2 Pavel Feldman 2012-04-03 00:51:26 PDT 
Comment on attachment 135279 [details]
Patch

I think database ids should be strings (in case we want unique ones).
Comment 3 Yury Semikhatsky 2012-04-03 02:51:57 PDT 
Created attachment 135294 [details]
Patch
Comment 4 Pavel Feldman 2012-04-03 05:01:39 PDT 
Comment on attachment 135294 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135294&action=review

> Source/WebCore/inspector/Inspector.json:885
> +                "id": "DatabaseIdentifier",

"DatabaseId"
Comment 5 Yury Semikhatsky 2012-04-03 05:02:37 PDT 
(In reply to comment #4)
> (From update of attachment 135294 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135294&action=review
> 
> > Source/WebCore/inspector/Inspector.json:885
> > +                "id": "DatabaseIdentifier",
> 
> "DatabaseId"

Done.
Comment 6 Yury Semikhatsky 2012-04-03 05:08:16 PDT 
Committed r113013: <http://trac.webkit.org/changeset/113013>