Bug 82958 – Web Inspector: CodeGeneratorInspector.py: switch Inspector, Memory and Database domains to typed API

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Peter Rybin]

Do not allow InspectorObject and other raw interfaces in Inspector, Memory and Database domains anymore.

[Peter Rybin]

Created attachment 135208 [details]
Patch

[Peter Rybin]

Please, take a look at new FIXME. This probably should be resovled before commit.

[WebKit Review Bot]

Attachment 135208 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InspectorDatabaseAgent.cpp:116:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yury Semikhatsky]

Comment on attachment 135208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135208&action=review

> Source/WebCore/inspector/InspectorDatabaseResource.cpp:62
> +        // FIXME: here we use string type according to Inspector.json.

Please file a bug on this and put its number next to FIXME.

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:205
> +    PassRefPtr<TypeBuilder::Array<TypeBuilder::Memory::DOMGroup> > domGroups() { return m_domGroups; }

Why did it become PassRefPtr?

[Yury Semikhatsky]

(In reply to comment #4)
> (From update of attachment 135208 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135208&action=review
> 
> > Source/WebCore/inspector/InspectorDatabaseResource.cpp:62
> > +        // FIXME: here we use string type according to Inspector.json.
> 
> Please file a bug on this and put its number next to FIXME.
> 
Nevermind, I've sent a fix for this https://bugs.webkit.org/show_bug.cgi?id=83003

[Peter Rybin]

Created attachment 135334 [details]
Patch

[Peter Rybin]

Comment on attachment 135208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135208&action=review

>> Source/WebCore/inspector/InspectorMemoryAgent.cpp:205
>> +    PassRefPtr<TypeBuilder::Array<TypeBuilder::Memory::DOMGroup> > domGroups() { return m_domGroups; }
> 
> Why did it become PassRefPtr?

Because we work in terms of RefPtr's everywhere here and there is no reason for transient switch to raw pointer.
A drive-by fix.

[WebKit Review Bot]

Attachment 135334 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InspectorDatabaseAgent.cpp:116:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Peter Rybin]

Created attachment 135339 [details]
Patch

[WebKit Review Bot]

Attachment 135339 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InspectorDatabaseAgent.cpp:116:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yury Semikhatsky]

Created attachment 135535 [details]
Patch for landing (with style errors fixed)

[Yury Semikhatsky]

(In reply to comment #10)
> Attachment 135339 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> Source/WebCore/inspector/InspectorDatabaseAgent.cpp:116:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
> Total errors found: 1 in 10 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Peter, next time please make sure style errors like this are resolved before landing.

[Yury Semikhatsky]

Committed r113157: <http://trac.webkit.org/changeset/113157>