Bug 82970 - Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
Summary: Move correction panel related functions from EditorClient into separated Alte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.7
: P2 Normal
Assignee: Jia Pu
URL:
Keywords: InRadar
Depends on: 82942
Blocks: 82503
  Show dependency treegraph
 
Reported: 2012-04-02 16:36 PDT by Jia Pu
Modified: 2012-04-05 11:18 PDT (History)
9 users (show)

See Also:


Attachments
Patch (v1). (63.40 KB, patch)
2012-04-04 16:52 PDT, Jia Pu
no flags Details | Formatted Diff | Diff
Fixing build on various platforms. (61.88 KB, patch)
2012-04-04 17:37 PDT, Jia Pu
no flags Details | Formatted Diff | Diff
Patch (V2) (64.78 KB, patch)
2012-04-04 23:05 PDT, Jia Pu
no flags Details | Formatted Diff | Diff
Fixing build. (66.42 KB, patch)
2012-04-05 00:10 PDT, Jia Pu
no flags Details | Formatted Diff | Diff
Fixing build. (68.05 KB, patch)
2012-04-05 01:06 PDT, Jia Pu
no flags Details | Formatted Diff | Diff
Fixing build. (66.75 KB, patch)
2012-04-05 07:00 PDT, Jia Pu
enrica: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jia Pu 2012-04-02 16:36:26 PDT
These functions are only used on OSX. This change is based on feedback in bug 82503.
Comment 1 Jia Pu 2012-04-02 16:47:19 PDT
<rdar://problem/11170898>
Comment 2 Jia Pu 2012-04-04 16:52:37 PDT
Created attachment 135722 [details]
Patch (v1).
Comment 3 Gustavo Noronha (kov) 2012-04-04 17:17:39 PDT
Comment on attachment 135722 [details]
Patch (v1).

Attachment 135722 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12335027
Comment 4 Jia Pu 2012-04-04 17:37:27 PDT
Created attachment 135730 [details]
Fixing build on various platforms.
Comment 5 Philippe Normand 2012-04-04 17:43:14 PDT
Comment on attachment 135730 [details]
Fixing build on various platforms.

Attachment 135730 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12335045
Comment 6 Build Bot 2012-04-04 18:05:48 PDT
Comment on attachment 135730 [details]
Fixing build on various platforms.

Attachment 135730 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12335049
Comment 7 Early Warning System Bot 2012-04-04 18:28:09 PDT
Comment on attachment 135730 [details]
Fixing build on various platforms.

Attachment 135730 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12341064
Comment 8 Jia Pu 2012-04-04 23:05:58 PDT
Created attachment 135760 [details]
Patch (V2)
Comment 9 Philippe Normand 2012-04-04 23:16:58 PDT
Comment on attachment 135760 [details]
Patch (V2)

Attachment 135760 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12335159
Comment 10 Early Warning System Bot 2012-04-04 23:25:27 PDT
Comment on attachment 135760 [details]
Patch (V2)

Attachment 135760 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12341164
Comment 11 Build Bot 2012-04-04 23:26:58 PDT
Comment on attachment 135760 [details]
Patch (V2)

Attachment 135760 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12337157
Comment 12 Jia Pu 2012-04-05 00:10:51 PDT
Created attachment 135767 [details]
Fixing build.
Comment 13 WebKit Review Bot 2012-04-05 00:14:15 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 14 Early Warning System Bot 2012-04-05 00:28:12 PDT
Comment on attachment 135767 [details]
Fixing build.

Attachment 135767 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12336174
Comment 15 Build Bot 2012-04-05 00:36:18 PDT
Comment on attachment 135767 [details]
Fixing build.

Attachment 135767 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12337177
Comment 16 Jia Pu 2012-04-05 01:06:22 PDT
Created attachment 135776 [details]
Fixing build.
Comment 17 Early Warning System Bot 2012-04-05 01:18:42 PDT
Comment on attachment 135776 [details]
Fixing build.

Attachment 135776 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12338157
Comment 18 Build Bot 2012-04-05 01:43:10 PDT
Comment on attachment 135776 [details]
Fixing build.

Attachment 135776 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12340199
Comment 19 Jia Pu 2012-04-05 07:00:31 PDT
Created attachment 135816 [details]
Fixing build.
Comment 20 Enrica Casucci 2012-04-05 10:40:06 PDT
Comment on attachment 135816 [details]
Fixing build.

View in context: https://bugs.webkit.org/attachment.cgi?id=135816&action=review

Looks good to me. Please add the null check on the m_frame per my comment above before landing.

> Source/WebCore/editing/AlternativeTextController.cpp:473
> +    return m_frame->page() ? m_frame->page()->alternativeTextClient() : 0;

Should you check also that m_frame is not null?
Comment 21 Jia Pu 2012-04-05 11:18:07 PDT
Committed r113340: <http://trac.webkit.org/changeset/113340>