We'd like to submit the big patch in bug 82503 with several stages. This patch renames class SpellingCorrectionController to AlternativeTextController, since it will also be used to control alternative dictation input on OSX.
<rdar://problem/11168786>
Created attachment 135179 [details] Patch (v1)
Created attachment 135244 [details] Patch (V2)
Updated to TOT.
Attachment 135244 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/editing/AlternativeTextController.h:75: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] Total errors found: 1 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 135244 [details] Patch (V2) Attachment 135244 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12311823
Created attachment 135254 [details] Attempt to fix gtk build.
Created attachment 135257 [details] Attempt to fix gtk and windows build.
Comment on attachment 135257 [details] Attempt to fix gtk and windows build. Thanks for splitting the orignal one. This looks OK. Please wait until bots become green.
Comment on attachment 135257 [details] Attempt to fix gtk and windows build. Rejecting attachment 135257 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: WebKit/mac/ChangeLog patching file Source/WebKit/mac/WebCoreSupport/CorrectionPanel.h patching file Source/WebKit/mac/WebCoreSupport/CorrectionPanel.mm patching file Source/WebKit/mac/WebCoreSupport/WebEditorClient.h patching file Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm patching file Source/WebKit/mac/WebView/WebView.mm Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Hajime Mor..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12323124
Created attachment 135349 [details] Resolved conflict with TOT.
Comment on attachment 135349 [details] Resolved conflict with TOT. It is a giant patch!
Comment on attachment 135349 [details] Resolved conflict with TOT. Rejecting attachment 135349 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 126079 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 47>At revision 126079. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/12319405
(In reply to comment #13) > (From update of attachment 135349 [details]) > Rejecting attachment 135349 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > Last 500 characters of output: > Kit/chromium/third_party/yasm/source/patched-yasm --revision 126079 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > 47>At revision 126079. > > ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > > ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > Updating webkit projects from gyp files... > > Full output: http://queues.webkit.org/results/12319405 hmmm, it's rather difficult to tell from these log what the culprit is. Any suggestion from webkit experts?
Keep running into submission issue. So I manually landed it. Committed r113109: <http://trac.webkit.org/changeset/113109>