Bug 82807 – styleForElement() should use enums instead of bools so we can all understand what it's doing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

styleForElement() should use enums instead of bools so we can all understand what it's doing

[Eric Seidel (no email)]

Created attachment 134915 [details]
Patch

[Adam Barth]

Comment on attachment 134915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134915&action=review

> Source/WebCore/rendering/RenderObject.cpp:2548
> +    /// FIXME: This "find nearest element parent" should be a helper function.

///////////////////

[WebKit Review Bot]

Attachment 134915 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSStyleSelector.cpp:1570:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Seidel (no email)]

Created attachment 134916 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 134916 [details]
Patch for landing

Rejecting attachment 134916 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
eSelector.h
patching file Source/WebCore/css/MediaQueryMatcher.cpp
patching file Source/WebCore/css/StyleMedia.cpp
patching file Source/WebCore/dom/Element.cpp
patching file Source/WebCore/rendering/RenderObject.cpp
Hunk #1 succeeded at 2560 (offset 15 lines).
patching file Source/WebCore/rendering/RenderRegion.cpp
patching file Source/WebCore/svg/SVGElement.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12267531

[Eric Seidel (no email)]

Created attachment 134928 [details]
Patch for landing

[WebKit Review Bot]

Attachment 134928 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSStyleSelector.cpp:1570:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 134928 [details]
Patch for landing

Clearing flags on attachment: 134928

Committed r112765: <http://trac.webkit.org/changeset/112765>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.