Bug 82449 – [EFL] LayoutTestController needs implementation of pageProperty

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Sudarsana Nagineni (babu)]

LayoutTestController needs implementation of pageProperty in order to unskip printing/page-rule-selection.html.

[Sudarsana Nagineni (babu)]

Created attachment 134270 [details]
Patch

DRT support for pageProperty

[Gyuyoung Kim]

Comment on attachment 134270 [details]
Patch

Looks good to me.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 134270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134270&action=review

> LayoutTests/platform/efl/Skipped:400
>  printing/page-format-data.html

If this one can't still be skipped yet, please update the comment informing what's missing in LTC.

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:138
> +    String property = DumpRenderTreeSupportEfl::pageProperty(browser->mainFrame(), propertyName, pageNumber);

Could be const.

[Sudarsana Nagineni (babu)]

(In reply to comment #3)
> > LayoutTests/platform/efl/Skipped:400
> >  printing/page-format-data.html
> 
> If this one can't still be skipped yet, please update the comment informing what's missing in LTC.

Forgot to update the comment. Thanks for review!

[Sudarsana Nagineni (babu)]

Created attachment 134538 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 134538 [details]
Patch

Looks fine, thanks.

[Sudarsana Nagineni (babu)]

Created attachment 136463 [details]
Patch

rebased

[WebKit Review Bot]

Comment on attachment 136463 [details]
Patch

Clearing flags on attachment: 136463

Committed r113893: <http://trac.webkit.org/changeset/113893>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.