Bug 82446 – [EFL] LayoutTestController needs implementation of addUserStyleSheet

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Sudarsana Nagineni (babu)]

LayoutTestController needs implementation of addUserStyleSheet in order to unskip the following tests.

userscripts/mixed-case-stylesheet.html 
userscripts/user-style-all-frames.html
userscripts/simple-stylesheet.html 
userscripts/script-run-at-end.html

[Sudarsana Nagineni (babu)]

Created attachment 134259 [details]
Patch

Add addUserStyleSheet implementation

[Gyuyoung Kim]

Comment on attachment 134259 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134259&action=review

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h:68
> +    static void addUserStyleSheet(Evas_Object* ewkView, const char* sourceCode, bool allFrames);

In my humble opinion, it is better to add const keyword in front of Evas_Object. Because EWKPrivate::corePage is defined as below,
http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_private.h#L95

In addition, you just use page object without ewkView's change. It seems you can add const keyword.

[Sudarsana Nagineni (babu)]

(In reply to comment #2)
> In my humble opinion, it is better to add const keyword in front of Evas_Object. Because EWKPrivate::corePage is defined as below,
> http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_private.h#L95
> 
> In addition, you just use page object without ewkView's change. It seems you can add const keyword.

Okay, thanks for your review!

[Sudarsana Nagineni (babu)]

Created attachment 134511 [details]
Patch

fix review comment #2

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 134511 [details]
Patch

Looks good to me.

[WebKit Review Bot]

Comment on attachment 134511 [details]
Patch

Clearing flags on attachment: 134511

Committed r113719: <http://trac.webkit.org/changeset/113719>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.