[chromium] Replicas should be included in the computed occlusion
Created attachment 133966 [details] Patch
Comment on attachment 133966 [details] Patch Looks good. Thanks as always for the tests. Can you put up a rebaselined patch?
Thanks, yup! Once bug #81227 is in I'll rebase this and throw it at EWS.
Created attachment 136376 [details] Patch Trashing your R+ cuz I am adding hasReplica() to RenderSurfaceChromium, and cuz you had asked for a rebased patch and I hadn't done that yet. The diff here is just adding RSChromium::hasReplica() for the templated functions in CCOcclusionTracker
Comment on attachment 136376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136376&action=review > Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.cpp:129 > + transformedRegion.unite(intersection(surface->clipRect(), enclosedIntRect(transform.mapRect(FloatRect(rects[i]))))); Oh this is wrong, need to check clipRect().isEmpty() first for a surface.
Created attachment 136386 [details] Patch
Comment on attachment 136386 [details] Patch Looks good to me.
Comment on attachment 136386 [details] Patch Clearing flags on attachment: 136386 Committed r114197: <http://trac.webkit.org/changeset/114197>
All reviewed patches have been landed. Closing bug.