Bug 82142 – Add a notification function for detaching to TextFieldDecorator

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

Add a notification function for detaching to TextFieldDecorator

[Kent Tamura]

Created attachment 133676 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 133676 [details]
Patch 

View in context: https://bugs.webkit.org/attachment.cgi?id=133676&action=review

ok.

> Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:68
> +inline HTMLInputElement* TextFieldDecorationElement::hostInput()
> +{
> +    ASSERT(shadowAncestorNode());
> +    ASSERT(shadowAncestorNode()->hasTagName(inputTag));
> +    return static_cast<HTMLInputElement*>(shadowAncestorNode());
> +}

We usually put these into the header, right?

[WebKit Review Bot]

Comment on attachment 133676 [details]
Patch 

Clearing flags on attachment: 133676

Committed r112109: <http://trac.webkit.org/changeset/112109>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kent Tamura]

Comment on attachment 133676 [details]
Patch 

Thank you for reviewing!

View in context: https://bugs.webkit.org/attachment.cgi?id=133676&action=review

>> Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:68
>> +}
> 
> We usually put these into the header, right?

I don't think we should do it in this case because
 - This function is private.
 - We need to include HTMLInputElement.h and HTMLNames.h to implement this function.