Bug 82142 - Add a notification function for detaching to TextFieldDecorator
Summary: Add a notification function for detaching to TextFieldDecorator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 80479 82143
  Show dependency tree / graph
 
Reported: 2012-03-25 03:45 PDT by Kent Tamura
Modified: 2012-03-27 18:05 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.44 KB, patch)
2012-03-25 03:52 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-03-25 03:45:02 PDT 
Add a notification function for detaching to TextFieldDecorator
Comment 1 Kent Tamura 2012-03-25 03:52:56 PDT 
Created attachment 133676 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2012-03-26 09:11:59 PDT 
Comment on attachment 133676 [details]
Patch 

View in context: https://bugs.webkit.org/attachment.cgi?id=133676&action=review

ok.

> Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:68
> +inline HTMLInputElement* TextFieldDecorationElement::hostInput()
> +{
> +    ASSERT(shadowAncestorNode());
> +    ASSERT(shadowAncestorNode()->hasTagName(inputTag));
> +    return static_cast<HTMLInputElement*>(shadowAncestorNode());
> +}

We usually put these into the header, right?
Comment 3 WebKit Review Bot 2012-03-26 09:19:19 PDT 
Comment on attachment 133676 [details]
Patch 

Clearing flags on attachment: 133676

Committed r112109: <http://trac.webkit.org/changeset/112109>
Comment 4 WebKit Review Bot 2012-03-26 09:19:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Kent Tamura 2012-03-27 18:05:05 PDT 
Comment on attachment 133676 [details]
Patch 

Thank you for reviewing!

View in context: https://bugs.webkit.org/attachment.cgi?id=133676&action=review

>> Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:68
>> +}
> 
> We usually put these into the header, right?

I don't think we should do it in this case because
 - This function is private.
 - We need to include HTMLInputElement.h and HTMLNames.h to implement this function.