Bug 81970 – Web Inspector: x-frame security errors logged when typing in the console are annoying.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[David Levin]

Created attachment 133350 [details]
outer frame

1. Save the two html documents to your local hard drive.
2. open test_iframe.html
3. open inspector and put a breakpoint in foo()
4. in the console type "window.frameElement" (Don't paste it. Actually type it.) or "window.parent.location", etc.
Note that you get lots of "Unsafe JavaScript attempt to access frame with URL" errors in the console output as you type. This makes using the console really painful.

Other:
* These steps as given may only repro with browsers like chromium that treat all local files as different security origins. (You need the inner frame to be a different security origin to repro the issue.)
* In my case, the errors don't collapse together (like they did for me in this simple example) -- perhaps that is because they have a stack trace.

[David Levin]

Created attachment 133351 [details]
inner frame

[Vsevolod Vlasov]

Created attachment 137688 [details]
Patch

[Build Bot]

Comment on attachment 137688 [details]
Patch

Attachment 137688 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12427225

[Pavel Feldman]

Comment on attachment 137688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137688&action=review

> Source/WebCore/inspector/PageRuntimeAgent.cpp:72
> +    Frame* mainFrame = m_inspectedPage->mainFrame();

I would use a counter here.

> Source/WebCore/inspector/PageRuntimeAgent.cpp:74
> +    for (Frame* frame = mainFrame; frame; frame = frame->tree()->traverseNext(mainFrame))

I would use a static counter on console instead.

[Vsevolod Vlasov]

Created attachment 137711 [details]
Patch

[Build Bot]

Comment on attachment 137711 [details]
Patch

Attachment 137711 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12429239

[Vsevolod Vlasov]

Created attachment 137725 [details]
Patch

[Pavel Feldman]

Comment on attachment 137725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137725&action=review

> Source/WebCore/page/Console.cpp:59
> +    int s_muteCount = 0;

Either declare it in the Console.h or stop using the s_ prefix.

[Vsevolod Vlasov]

Committed r114628: <http://trac.webkit.org/changeset/114628>

[Csaba Osztrogonác]

Reopen, because it broke the debug build on Qt:
../../../../Source/WebCore/inspector/InspectorDebuggerAgent.cpp: In member function ‘virtual void WebCore::InspectorDebuggerAgent::evaluateOnCallFrame(WebCore::ErrorString*, const WTF::String&, const WTF::String&, const WTF::String*, const bool*, const bool*, const bool*, WTF::RefPtr<WebCore::TypeBuilder::Runtime::RemoteObject>&, WebCore::TypeBuilder::OptOutput<bool>*)’:
../../../../Source/WebCore/inspector/InspectorDebuggerAgent.cpp:492: error: no match for ‘operator!’ in ‘!WebCore::InspectorDebuggerAgent::scriptDebugServer()’
../../../../Source/WebCore/inspector/InspectorDebuggerAgent.cpp:492: note: candidates are: operator!(bool) <built-in>

[Vsevolod Vlasov]

Created attachment 137901 [details]
Patch

[Vsevolod Vlasov]

Committed r114632: <http://trac.webkit.org/changeset/114632>

[Timothy Hatcher]

Renaming the existing doNotPauseOnExceptions parameter to doNotPauseOnExceptionsAndMuteConsole breaks backward compatibility with version 1.0 of the protocol. Renames should not be allowed.

Am I correct? If so I'll file a bug about making the compatibility checking catch such things.

[Pavel Feldman]

(In reply to comment #13)
> Renaming the existing doNotPauseOnExceptions parameter to doNotPauseOnExceptionsAndMuteConsole breaks backward compatibility with version 1.0 of the protocol. Renames should not be allowed.
> 
> Am I correct? If so I'll file a bug about making the compatibility checking catch such things.

We do not guarantee compatibility of the hidden members (methods, parameters, etc). It is explicitly stated in the announcement and these members are missing in the documentation.

[Timothy Hatcher]

(In reply to comment #14)
> (In reply to comment #13)
> > Renaming the existing doNotPauseOnExceptions parameter to doNotPauseOnExceptionsAndMuteConsole breaks backward compatibility with version 1.0 of the protocol. Renames should not be allowed.
> > 
> > Am I correct? If so I'll file a bug about making the compatibility checking catch such things.
> 
> We do not guarantee compatibility of the hidden members (methods, parameters, etc). It is explicitly stated in the announcement and these members are missing in the documentation.

Sorry, I overlooked the fact that it was hidden. Too many things are hidden, so the protocol is pretty useless without using hidden members.

What is your process and timeframe for unhiding minor things like this?

[Pavel Feldman]

> What is your process and timeframe for unhiding minor things like this?

There is really no process / schedule for that. You should probably file bugs for such changes.