You need to
before you can comment on or make changes to this bug.
fast/events/suspend-timers.html is failing in Mac WebKit2, but passes in Safari. The test relies on enabling the page cache using layoutTestController.overridePreference('WebKitUsesPageCachePreferenceKey', 1). Even though this function is implemented in WebKitTestRunner, it may not be achieving the desired effect.
Added the current incorrect results as Mac WebKit2 expected results in <http://trac.webkit.org/r111741>.
The failing results are inconsistent, so I am going to skip the test in Mac WebKit2.
Added to the Mac WebKit2 skip list in <http://trac.webkit.org/r111761>.
Created an attachment (id=137208) [details]
Alternatively, CacheModel can be set to PrimaryWebBrowser, only when the PageCache's preference key is also set to enabled. Though, I believe it's better to run WebKitTestRunner with PrimaryWebBrowser setting instead of that DocumentViewer.
*** Bug 81637 has been marked as a duplicate of this bug. ***
(From update of attachment 137208 [details])
It looks like DumpRenderTree (on Mac, at least) uses WebCacheModelDocumentBrowser. Shouldn’t WebKitTestRunner use the same by default?
(In reply to comment #8)
> (From update of attachment 137208 [details] [details])
> It looks like DumpRenderTree (on Mac, at least) uses WebCacheModelDocumentBrowser. Shouldn’t WebKitTestRunner use the same by default?
The only reason I picked PrimaryWebBrowser was because it guarantees capacity > 0. However for compatibility reasons, i guess DocumentBrowser is a better pick.
Created an attachment (id=137213) [details]
(From update of attachment 137213 [details])
Clearing flags on attachment: 137213
Committed r114206: <http://trac.webkit.org/changeset/114206>
All reviewed patches have been landed. Closing bug.
This commit broke the LayoutTests/fast/harness/use-page-cache.html test on Lion and Snow Leopard.
Filed <https://bugs.webkit.org/show_bug.cgi?id=84206> to track the test failure.