Bug 81640 - Make animVal support type-safe
Summary: Make animVal support type-safe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on: 12437
Blocks: 41761
  Show dependency tree / graph
 
Reported: 2012-03-20 02:18 PDT by Nikolas Zimmermann
Modified: 2012-03-20 04:47 PDT (History)
3 users (show)

See Also:

Attachments
Patch (73.99 KB, patch)
2012-03-20 04:18 PDT, Nikolas Zimmermann 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2012-03-20 02:18:59 PDT 
As discussed with Antti, we should remove SVGGenericAnimatedType, and the associated reinterpret_cast, and replace it with a type-safe solution, even if it requires some boilerplate code.
It was a poor decision to go with it initially, so I'm going to redesign it.
Comment 1 Nikolas Zimmermann 2012-03-20 04:18:19 PDT 
Created attachment 132794 [details]
Patch
Comment 2 Antti Koivisto 2012-03-20 04:41:49 PDT 
Comment on attachment 132794 [details]
Patch

r=me, with naming consistency fixes discussed in irc
Comment 3 Nikolas Zimmermann 2012-03-20 04:47:46 PDT 
Committed r111380: <http://trac.webkit.org/changeset/111380>