[chromium] Push culled tiles that are prepainted
Created attachment 132652 [details] Patch
To be clear, during an idle paint, we still attempt to VisiblePaint, which would mark the tile culled. Then even though we would actually idle-paint the tile, we would not push it to the impl thread.
Created attachment 132678 [details] Patch
Comment on attachment 132652 [details] Patch Fix this up a bit. I want a tile to be marked as "updated" ie not culled if it was updated on any pass through prepareToUpdateTiles. Previous version depended on the fact that PaintVisible culled and PaintIdle did not, this one is more robust.
Comment on attachment 132652 [details] Patch Looks good to me.
Comment on attachment 132678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132678&action=review I like this one better too. One small nit: > Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp:-432 > - tile->m_updateCulled = true; Can you add an assert(!tile->m_updated) here, since this would cause issues if m_updateRect got touched but somehow m_updated was true?
Comment on attachment 132678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132678&action=review >> Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp:-432 >> - tile->m_updateCulled = true; > > Can you add an assert(!tile->m_updated) here, since this would cause issues if m_updateRect got touched but somehow m_updated was true? Yeh, great plan. Thanks.
Created attachment 132737 [details] Patch
Comment on attachment 132737 [details] Patch Clearing flags on attachment: 132737 Committed r111335: <http://trac.webkit.org/changeset/111335>
All reviewed patches have been landed. Closing bug.