Bug 81529 – [chromium] Invalidate/update evicted tiles during commit

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dana Jansens]

[chromium] Invalidate/update evicted tiles during commit

[Dana Jansens]

Created attachment 132614 [details]
Patch

[WebKit Review Bot]

Attachment 132614 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:12:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dana Jansens]

Created attachment 132617 [details]
Patch

[Adrienne Walker]

Comment on attachment 132617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132617&action=review

Sorry for not catching this issue the first time through review.

> Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp:370
> +    EXPECT_TRUE(layerImpl->hasTileAt(0, 0));
> +    EXPECT_FALSE(layerImpl->hasTileAt(0, 1));

Can you also verify after a pushPropertiesTo that neither tile is there? I don't think we have any test related to that.

[Adrienne Walker]

(In reply to comment #4)
> (From update of attachment 132617 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=132617&action=review
> 
> Sorry for not catching this issue the first time through review.
> 
> > Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp:370
> > +    EXPECT_TRUE(layerImpl->hasTileAt(0, 0));
> > +    EXPECT_FALSE(layerImpl->hasTileAt(0, 1));
> 
> Can you also verify after a pushPropertiesTo that neither tile is there? I don't think we have any test related to that.

...before doing any painting, I mean.

[Dana Jansens]

Created attachment 132644 [details]
Patch

Thanks! Done!

[WebKit Review Bot]

Comment on attachment 132644 [details]
Patch

Clearing flags on attachment: 132644

Committed r111253: <http://trac.webkit.org/changeset/111253>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.