WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 81536
[BlackBerry] speed up text selection for large selections
https://bugs.webkit.org/show_bug.cgi?id=81536
Summary
[BlackBerry] speed up text selection for large selections
tabbott
Reported
2012-03-19 12:15:21 PDT
Doing a selectAll on
http://en.wikipedia.org/wiki/Albert_Einstein
takes more than one second (1.395534s). Most of the time is spent creating the consolidated IntRectRegion.
Attachments
fast patch
(3.54 KB, patch)
2012-03-19 14:00 PDT
,
tabbott
rwlbuis
: review-
rwlbuis
: commit-queue+
Details
Formatted Diff
Diff
extra prefixes removed
(3.50 KB, patch)
2012-03-19 14:10 PDT
,
tabbott
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
tabbott
Comment 1
2012-03-19 12:44:11 PDT
Internal PR 136593
tabbott
Comment 2
2012-03-19 14:00:53 PDT
Created
attachment 132662
[details]
fast patch
Rob Buis
Comment 3
2012-03-19 14:09:01 PDT
Comment on
attachment 132662
[details]
fast patch View in context:
https://bugs.webkit.org/attachment.cgi?id=132662&action=review
Can fix some prefixes.
> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:118 > + BlackBerry::Platform::IntRect selectionBoundingBox;
Probably don't need the BlackBerry prefix.
tabbott
Comment 4
2012-03-19 14:10:29 PDT
Created
attachment 132666
[details]
extra prefixes removed
Rob Buis
Comment 5
2012-03-19 14:13:06 PDT
Comment on
attachment 132666
[details]
extra prefixes removed LGTM.
WebKit Review Bot
Comment 6
2012-03-19 15:17:50 PDT
Comment on
attachment 132666
[details]
extra prefixes removed Clearing flags on attachment: 132666 Committed
r111259
: <
http://trac.webkit.org/changeset/111259
>
WebKit Review Bot
Comment 7
2012-03-19 15:17:55 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug