Bug 81536 - [BlackBerry] speed up text selection for large selections
Summary: [BlackBerry] speed up text selection for large selections
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 525.x (Safari 3.2)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
Depends on: 82650
  Show dependency treegraph
Reported: 2012-03-19 12:15 PDT by tabbott
Modified: 2012-03-29 13:34 PDT (History)
2 users (show)

See Also:

fast patch (3.54 KB, patch)
2012-03-19 14:00 PDT, tabbott
rwlbuis: review-
rwlbuis: commit-queue+
Details | Formatted Diff | Diff
extra prefixes removed (3.50 KB, patch)
2012-03-19 14:10 PDT, tabbott
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tabbott 2012-03-19 12:15:21 PDT
Doing a selectAll on http://en.wikipedia.org/wiki/Albert_Einstein takes more than one second (1.395534s). Most of the time is spent creating the consolidated IntRectRegion.
Comment 1 tabbott 2012-03-19 12:44:11 PDT
Internal PR 136593
Comment 2 tabbott 2012-03-19 14:00:53 PDT
Created attachment 132662 [details]
fast patch
Comment 3 Rob Buis 2012-03-19 14:09:01 PDT
Comment on attachment 132662 [details]
fast patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132662&action=review

Can fix some prefixes.

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:118
> +        BlackBerry::Platform::IntRect selectionBoundingBox;

Probably don't need the BlackBerry prefix.
Comment 4 tabbott 2012-03-19 14:10:29 PDT
Created attachment 132666 [details]
extra prefixes removed
Comment 5 Rob Buis 2012-03-19 14:13:06 PDT
Comment on attachment 132666 [details]
extra prefixes removed

Comment 6 WebKit Review Bot 2012-03-19 15:17:50 PDT
Comment on attachment 132666 [details]
extra prefixes removed

Clearing flags on attachment: 132666

Committed r111259: <http://trac.webkit.org/changeset/111259>
Comment 7 WebKit Review Bot 2012-03-19 15:17:55 PDT
All reviewed patches have been landed.  Closing bug.