Bug 81377 – REGRESSION(r111020): Broke Chromium Win compile (Requested by pkasting on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/111020 broke the build:
Broke Chromium Win compile (Requested by pkasting on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 132327 [details]
ROLLOUT of r111020

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Peter Kasting]

Comment on attachment 132327 [details]
ROLLOUT of r111020

Clearing flags on attachment: 132327

Committed r111035: <http://trac.webkit.org/changeset/111035>

[Peter Kasting]

All reviewed patches have been landed.  Closing bug.

[Adam Barth]

Peter, do you have a link to the compile error?

[Adam Barth]

7>e:\b\chromium-win-release-tests\build\Source\JavaScriptCore\wtf/PassRefPtr.h(52) : error C2027: use of undefined type 'WebCore::MediaHints'
7>        e:\b\chromium-win-release-tests\build\source\webcore\platform\mediastream\PeerConnection00Handler.h(45) : see declaration of 'WebCore::MediaHints'
7>        e:\b\chromium-win-release-tests\build\Source\JavaScriptCore\wtf/PassRefPtr.h(67) : see reference to function template instantiation 'void WTF::derefIfNotNull<T>(T *)' being compiled
7>        with
7>        [
7>            T=WebCore::MediaHints
7>        ]
7>        e:\b\chromium-win-release-tests\build\Source\JavaScriptCore\wtf/PassRefPtr.h(67) : while compiling class template member function 'WTF::PassRefPtr<T>::~PassRefPtr(void)'
7>        with
7>        [
7>            T=WebCore::MediaHints
7>        ]
7>        ..\platform\mediastream\PeerConnection00Handler.cpp(61) : see reference to class template instantiation 'WTF::PassRefPtr<T>' being compiled
7>        with
7>        [
7>            T=WebCore::MediaHints
7>        ]
7>e:\b\chromium-win-release-tests\build\Source\JavaScriptCore\wtf/PassRefPtr.h(52) : error C2227: left of '->deref' must point to class/struct/union/generic type
7>e:\b\chromium-win-release-tests\build\Source\JavaScriptCore\wtf/PassRefPtr.h(52) : error C2027: use of undefined type 'WebCore::IceOptions'
7>        e:\b\chromium-win-release-tests\build\source\webcore\platform\mediastream\PeerConnection00Handler.h(44) : see declaration of 'WebCore::IceOptions'
7>        e:\b\chromium-win-release-tests\build\Source\JavaScriptCore\wtf/PassRefPtr.h(67) : see reference to function template instantiation 'void WTF::derefIfNotNull<T>(T *)' being compiled
7>        with
7>        [
7>            T=WebCore::IceOptions
7>        ]
7>        e:\b\chromium-win-release-tests\build\Source\JavaScriptCore\wtf/PassRefPtr.h(67) : while compiling class template member function 'WTF::PassRefPtr<T>::~PassRefPtr(void)'
7>        with
7>        [
7>            T=WebCore::IceOptions
7>        ]
7>        ..\platform\mediastream\PeerConnection00Handler.cpp(91) : see reference to class template instantiation 'WTF::PassRefPtr<T>' being compiled
7>        with
7>        [
7>            T=WebCore::IceOptions
7>        ]
7>e:\b\chromium-win-release-tests\build\Source\JavaScriptCore\wtf/PassRefPtr.h(52) : error C2227: left of '->deref' must point to class/struct/union/generic type

[Adam Barth]

Found it:  http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/24492/steps/compile-webkit/logs/stdio

Thanks!