In preparation of the last WebCore patch that will introduce PeerConnection00 here's its platform representation.
Created attachment 132251 [details] Patch
Created attachment 132266 [details] Patch
Comment on attachment 132266 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132266&action=review > Source/WebCore/platform/mediastream/PeerConnection00Handler.cpp:65 > +PassRefPtr<SessionDescriptionDescriptor> PeerConnection00Handler::createAnswer(const String& offer, PassRefPtr<MediaHints>) You might need to add UNUSED_PARAM(offer) for some ports.
Comment on attachment 132266 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132266&action=review >> Source/WebCore/platform/mediastream/PeerConnection00Handler.cpp:65 >> +PassRefPtr<SessionDescriptionDescriptor> PeerConnection00Handler::createAnswer(const String& offer, PassRefPtr<MediaHints>) > > You might need to add UNUSED_PARAM(offer) for some ports. I'll just remove all argument names , these are just dummy implementations after all. OK?
Created attachment 132276 [details] Patch
Comment on attachment 132276 [details] Patch Clearing flags on attachment: 132276 Committed r111020: <http://trac.webkit.org/changeset/111020>
All reviewed patches have been landed. Closing bug.
This broke Chromium Win compile: http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/24486/steps/compile-webkit/logs/stdio tommyw and abarth don't seem to be around, I plan to roll out and reopen.
Rolled out in r111035.
Created attachment 132570 [details] Patch
Hopefully fixed build break by adding the necessary headers to Source/WebCore/platform/mediastream/PeerConnection00Handler.cpp Strange that all other compilers optimized away the unused references, but windows failed.
Comment on attachment 132570 [details] Patch Ok.
Comment on attachment 132570 [details] Patch Clearing flags on attachment: 132570 Committed r111208: <http://trac.webkit.org/changeset/111208>