Bug 81333 - MediaStream API (JSEP): Introducing PeerConnection00Handler
Summary: MediaStream API (JSEP): Introducing PeerConnection00Handler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on: 81377
Blocks: 80589
  Show dependency treegraph
 
Reported: 2012-03-16 04:47 PDT by Tommy Widenflycht
Modified: 2012-03-19 11:33 PDT (History)
3 users (show)

See Also:


Attachments
Patch (14.12 KB, patch)
2012-03-16 04:52 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff
Patch (14.12 KB, patch)
2012-03-16 06:13 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff
Patch (14.10 KB, patch)
2012-03-16 07:08 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff
Patch (14.12 KB, patch)
2012-03-19 06:56 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-03-16 04:47:35 PDT
In preparation of the last WebCore patch that will introduce PeerConnection00 here's its platform representation.
Comment 1 Tommy Widenflycht 2012-03-16 04:52:29 PDT
Created attachment 132251 [details]
Patch
Comment 2 Tommy Widenflycht 2012-03-16 06:13:19 PDT
Created attachment 132266 [details]
Patch
Comment 3 Adam Barth 2012-03-16 06:50:04 PDT
Comment on attachment 132266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132266&action=review

> Source/WebCore/platform/mediastream/PeerConnection00Handler.cpp:65
> +PassRefPtr<SessionDescriptionDescriptor> PeerConnection00Handler::createAnswer(const String& offer, PassRefPtr<MediaHints>)

You might need to add UNUSED_PARAM(offer) for some ports.
Comment 4 Tommy Widenflycht 2012-03-16 06:58:00 PDT
Comment on attachment 132266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132266&action=review

>> Source/WebCore/platform/mediastream/PeerConnection00Handler.cpp:65
>> +PassRefPtr<SessionDescriptionDescriptor> PeerConnection00Handler::createAnswer(const String& offer, PassRefPtr<MediaHints>)
> 
> You might need to add UNUSED_PARAM(offer) for some ports.

I'll just remove all argument names , these are just dummy implementations after all. OK?
Comment 5 Tommy Widenflycht 2012-03-16 07:08:38 PDT
Created attachment 132276 [details]
Patch
Comment 6 WebKit Review Bot 2012-03-16 09:57:19 PDT
Comment on attachment 132276 [details]
Patch

Clearing flags on attachment: 132276

Committed r111020: <http://trac.webkit.org/changeset/111020>
Comment 7 WebKit Review Bot 2012-03-16 09:57:23 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Peter Kasting 2012-03-16 11:21:19 PDT
This broke Chromium Win compile: http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/24486/steps/compile-webkit/logs/stdio

tommyw and abarth don't seem to be around, I plan to roll out and reopen.
Comment 9 Peter Kasting 2012-03-16 11:34:05 PDT
Rolled out in r111035.
Comment 10 Tommy Widenflycht 2012-03-19 06:56:18 PDT
Created attachment 132570 [details]
Patch
Comment 11 Tommy Widenflycht 2012-03-19 06:58:55 PDT
Hopefully fixed build break by adding the necessary headers to Source/WebCore/platform/mediastream/PeerConnection00Handler.cpp

Strange that all other compilers optimized away the unused references, but windows failed.
Comment 12 Adam Barth 2012-03-19 11:10:23 PDT
Comment on attachment 132570 [details]
Patch

Ok.
Comment 13 WebKit Review Bot 2012-03-19 11:33:38 PDT
Comment on attachment 132570 [details]
Patch

Clearing flags on attachment: 132570

Committed r111208: <http://trac.webkit.org/changeset/111208>
Comment 14 WebKit Review Bot 2012-03-19 11:33:42 PDT
All reviewed patches have been landed.  Closing bug.