Bug 81222 - [chromium] Changes to overdraw metrics to allow upload tracking
Summary: [chromium] Changes to overdraw metrics to allow upload tracking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on: 81156
Blocks: 81175 81242
  Show dependency tree / graph
 
Reported: 2012-03-15 08:11 PDT by Dana Jansens
Modified: 2012-03-16 02:20 PDT (History)
7 users (show)

See Also:

Attachments
Patch (37.42 KB, patch)
2012-03-15 08:19 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Patch (37.52 KB, patch)
2012-03-15 17:51 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-03-15 08:11:02 PDT 
[chromium] Changes to overdraw metrics to all upload tracking
Comment 1 Dana Jansens 2012-03-15 08:19:18 PDT 
Created attachment 132054 [details]
Patch
Comment 2 Adrienne Walker 2012-03-15 13:23:44 PDT 
Comment on attachment 132054 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132054&action=review

R=me.  It makes sense to rename painting to upload, since we may paint much more if we're not using per-tile painting.

> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.h:113
> +    OwnPtr<CCOverdrawMetrics> m_overdrawMetrics;

nit: Maybe make this a local, since you always create it and return a reference to it?
Comment 3 Dana Jansens 2012-03-15 13:25:01 PDT 
Comment on attachment 132054 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132054&action=review

Thanks!

>> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.h:113
>> +    OwnPtr<CCOverdrawMetrics> m_overdrawMetrics;
> 
> nit: Maybe make this a local, since you always create it and return a reference to it?

I agree, but then I can't pass a const CCOcclusionTracker around to culling. WDYT is better?
Comment 4 Adrienne Walker 2012-03-15 13:36:38 PDT 
Comment on attachment 132054 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132054&action=review

>>> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.h:113
>>> +    OwnPtr<CCOverdrawMetrics> m_overdrawMetrics;
>> 
>> nit: Maybe make this a local, since you always create it and return a reference to it?
> 
> I agree, but then I can't pass a const CCOcclusionTracker around to culling. WDYT is better?

Ah, I see.  What's in the patch seems reasonable given that.
Comment 5 Dana Jansens 2012-03-15 17:51:24 PDT 
Created attachment 132164 [details]
Patch
Comment 6 WebKit Review Bot 2012-03-16 02:20:45 PDT 
Comment on attachment 132164 [details]
Patch

Clearing flags on attachment: 132164

Committed r110973: <http://trac.webkit.org/changeset/110973>
Comment 7 WebKit Review Bot 2012-03-16 02:20:49 PDT 
All reviewed patches have been landed.  Closing bug.