RESOLVED FIXED81156
[chromium] Move overdraw metrics into a templated class for both paint and draw metrics. 
https://bugs.webkit.org/show_bug.cgi?id=81156
Summary [chromium] Move overdraw metrics into a templated class for both paint and dr...
Dana Jansens
Reported 2012-03-14 13:56:49 PDT
[chromium] Move overdraw metrics into a templated class for both paint and draw metrics.
Attachments
Patch (33.50 KB, patch)
2012-03-14 14:01 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (37.17 KB, patch)
2012-03-14 15:24 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (34.24 KB, patch)
2012-03-14 16:16 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-03-14 14:01:22 PDT
Created attachment 131919 [details] Patch
Dana Jansens
Comment 2 2012-03-14 14:04:09 PDT
(Also adds TRACE_COUNTER_ID1 for the non-normalized values)
Nat Duca
Comment 3 2012-03-14 14:59:44 PDT
Comment on attachment 131919 [details] Patch We have TRACE_COUNTER_ID2 where you can do stuff like "bytesAllocated,bytesFree" and get both into a single counter. Can we pile this into there so we have 1 counter rather than 3? If we need support for 3-value counters, its all supported and we just need to add it to the trace_event macros .... jbates can help there.
Dana Jansens
Comment 4 2012-03-14 15:24:00 PDT
(In reply to comment #3) > (From update of attachment 131919 [details]) > We have TRACE_COUNTER_ID2 where you can do stuff like "bytesAllocated,bytesFree" and get both into a single counter. Can we pile this into there so we have 1 counter rather than 3? If we need support for 3-value counters, its all supported and we just need to add it to the trace_event macros .... jbates can help there. Yep, done!
Dana Jansens
Comment 5 2012-03-14 15:24:40 PDT
Created attachment 131933 [details] Patch
Dana Jansens
Comment 6 2012-03-14 16:16:09 PDT
Created attachment 131951 [details] Patch Using a single event to record both opaque/translucent pixel counts. Tested this out with about:tracing and it seems pretty reasonable, you can drill in and find pixel counts when you need to, until something better in the about:tracing system comes along.
Adrienne Walker
Comment 7 2012-03-15 09:29:54 PDT
Comment on attachment 131951 [details] Patch R=me. Why counter+event rather than three counters? That seems reasonable too, but I'm just curious why the change?
Dana Jansens
Comment 8 2012-03-15 09:31:46 PDT
(In reply to comment #7) > (From update of attachment 131951 [details]) > R=me. Why counter+event rather than three counters? That seems reasonable too, but I'm just curious why the change? Nat was concerned about too many bars on about:tracing.
WebKit Review Bot
Comment 9 2012-03-15 17:45:43 PDT
Comment on attachment 131951 [details] Patch Clearing flags on attachment: 131951 Committed r110921: <http://trac.webkit.org/changeset/110921>
WebKit Review Bot
Comment 10 2012-03-15 17:45:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.