Bug 81156 - [chromium] Move overdraw metrics into a templated class for both paint and draw metrics.
Summary: [chromium] Move overdraw metrics into a templated class for both paint and dr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks: 81175 81222
  Show dependency treegraph
 
Reported: 2012-03-14 13:56 PDT by Dana Jansens
Modified: 2012-03-15 17:45 PDT (History)
9 users (show)

See Also:


Attachments
Patch (33.50 KB, patch)
2012-03-14 14:01 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch (37.17 KB, patch)
2012-03-14 15:24 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch (34.24 KB, patch)
2012-03-14 16:16 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-03-14 13:56:49 PDT
[chromium] Move overdraw metrics into a templated class for both paint and draw metrics.
Comment 1 Dana Jansens 2012-03-14 14:01:22 PDT
Created attachment 131919 [details]
Patch
Comment 2 Dana Jansens 2012-03-14 14:04:09 PDT
(Also adds TRACE_COUNTER_ID1 for the non-normalized values)
Comment 3 Nat Duca 2012-03-14 14:59:44 PDT
Comment on attachment 131919 [details]
Patch

We have TRACE_COUNTER_ID2 where you can do stuff like "bytesAllocated,bytesFree" and get both into a single counter. Can we pile this into there so we have 1 counter rather than 3? If we need support for 3-value counters, its all supported and we just need to add it to the trace_event macros .... jbates can help there.
Comment 4 Dana Jansens 2012-03-14 15:24:00 PDT
(In reply to comment #3)
> (From update of attachment 131919 [details])
> We have TRACE_COUNTER_ID2 where you can do stuff like "bytesAllocated,bytesFree" and get both into a single counter. Can we pile this into there so we have 1 counter rather than 3? If we need support for 3-value counters, its all supported and we just need to add it to the trace_event macros .... jbates can help there.

Yep, done!
Comment 5 Dana Jansens 2012-03-14 15:24:40 PDT
Created attachment 131933 [details]
Patch
Comment 6 Dana Jansens 2012-03-14 16:16:09 PDT
Created attachment 131951 [details]
Patch

Using a single event to record both opaque/translucent pixel counts. Tested this out with about:tracing and it seems pretty reasonable, you can drill in and find pixel counts when you need to, until something better in the about:tracing system comes along.
Comment 7 Adrienne Walker 2012-03-15 09:29:54 PDT
Comment on attachment 131951 [details]
Patch

R=me.  Why counter+event rather than three counters? That seems reasonable too, but I'm just curious why the change?
Comment 8 Dana Jansens 2012-03-15 09:31:46 PDT
(In reply to comment #7)
> (From update of attachment 131951 [details])
> R=me.  Why counter+event rather than three counters? That seems reasonable too, but I'm just curious why the change?

Nat was concerned about too many bars on about:tracing.
Comment 9 WebKit Review Bot 2012-03-15 17:45:43 PDT
Comment on attachment 131951 [details]
Patch

Clearing flags on attachment: 131951

Committed r110921: <http://trac.webkit.org/changeset/110921>
Comment 10 WebKit Review Bot 2012-03-15 17:45:49 PDT
All reviewed patches have been landed.  Closing bug.