Bug 81219 - Enable animVal support for SVGNumberList
Summary: Enable animVal support for SVGNumberList
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on: 12437
Blocks: 41761
  Show dependency tree / graph
 
Reported: 2012-03-15 07:29 PDT by Nikolas Zimmermann
Modified: 2012-03-15 08:28 PDT (History)
1 user (show)

See Also:

Attachments
Patch (18.38 KB, patch)
2012-03-15 07:45 PDT, Nikolas Zimmermann 		rwlbuis: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2012-03-15 07:29:09 PDT 
Enable animVal support for SVGNumberList.
Easy patch, as all ground-work is done.
Comment 1 Nikolas Zimmermann 2012-03-15 07:45:29 PDT 
Created attachment 132045 [details]
Patch
Comment 2 Rob Buis 2012-03-15 07:56:37 PDT 
Comment on attachment 132045 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132045&action=review

LGTM.

> Source/WebCore/svg/SVGAnimatedNumberList.h:49
> +    virtual PassOwnPtr<SVGAnimatedType> constructFromCopy(SVGGenericAnimatedType*);

As discussed on irc, constructFromVariant may be a better name.
Comment 3 Nikolas Zimmermann 2012-03-15 08:28:19 PDT 
Committed r110848: <http://trac.webkit.org/changeset/110848>