Bug 81118 - [BlackBerry] Syncing up left over bits in WebKitSupport from our local branch to upstream
Summary: [BlackBerry] Syncing up left over bits in WebKitSupport from our local branch...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks: 81108
  Show dependency tree / graph
 
Reported: 2012-03-14 08:56 PDT by Nima Ghanavatian
Modified: 2012-03-16 16:46 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.43 KB, patch)
2012-03-14 09:01 PDT, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Patch (10.43 KB, patch)
2012-03-14 10:19 PDT, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Patch (10.56 KB, patch)
2012-03-16 12:47 PDT, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2012-03-14 08:56:10 PDT 
This is a consolidation of various changes that are in our local dev branch but do not appear in our upstreamed port.
Comment 1 Nima Ghanavatian 2012-03-14 09:01:09 PDT 
Created attachment 131866 [details]
Patch
Comment 2 Rob Buis 2012-03-14 09:05:55 PDT 
Comment on attachment 131866 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131866&action=review

Looks good, but see the typo.

> Source/WebKit/blackberry/ChangeLog:3
> +        [BlackBerry] Syncing up left over bits in WebKitSupport from our local branch to ups    tream 

Copy paste error? :)
Comment 3 Nima Ghanavatian 2012-03-14 10:19:57 PDT 
Created attachment 131875 [details]
Patch
Comment 4 Rob Buis 2012-03-14 10:28:41 PDT 
Comment on attachment 131875 [details]
Patch

Looks good.
Comment 5 Nima Ghanavatian 2012-03-14 19:06:38 PDT 
Pulling from commit-queue.
Noticed some errors in this commit.  Will have to rework it.
Comment 6 Nima Ghanavatian 2012-03-16 12:47:49 PDT 
Created attachment 132353 [details]
Patch
Comment 7 Rob Buis 2012-03-16 12:50:22 PDT 
Comment on attachment 132353 [details]
Patch

LGTM.
Comment 8 WebKit Review Bot 2012-03-16 16:46:31 PDT 
Comment on attachment 132353 [details]
Patch

Clearing flags on attachment: 132353

Committed r111087: <http://trac.webkit.org/changeset/111087>
Comment 9 WebKit Review Bot 2012-03-16 16:46:36 PDT 
All reviewed patches have been landed.  Closing bug.