Bug 81108 - [BlackBerry] Rename the existing WebPageCompositor class to WebPageCompositorPrivate
Summary: [BlackBerry] Rename the existing WebPageCompositor class to WebPageCompositor...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 81099 81118
Blocks: 81115
  Show dependency treegraph
 
Reported: 2012-03-14 08:01 PDT by Arvid Nilsson
Modified: 2012-03-16 17:41 PDT (History)
4 users (show)

See Also:


Attachments
Patch (23.54 KB, patch)
2012-03-14 08:11 PDT, Arvid Nilsson
no flags Details | Formatted Diff | Diff
Patch (23.38 KB, patch)
2012-03-14 09:47 PDT, Arvid Nilsson
no flags Details | Formatted Diff | Diff
Patch (23.21 KB, patch)
2012-03-16 17:09 PDT, Arvid Nilsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2012-03-14 08:01:03 PDT
[BlackBerry] Rename the existing WebPageCompositor class to WebPageCompositorPrivate
Comment 1 Arvid Nilsson 2012-03-14 08:11:18 PDT
Created attachment 131849 [details]
Patch
Comment 2 Arvid Nilsson 2012-03-14 08:22:14 PDT
Change component
Comment 3 Rob Buis 2012-03-14 08:25:05 PDT
Comment on attachment 131849 [details]
Patch

Looks good. But should the file name change as well to reflect the new class name?
Comment 4 Arvid Nilsson 2012-03-14 09:47:05 PDT
Created attachment 131872 [details]
Patch
Comment 5 Arvid Nilsson 2012-03-14 09:48:00 PDT
(In reply to comment #3)
> (From update of attachment 131849 [details])
> Looks good. But should the file name change as well to reflect the new class name?

No, it should not. The implementation of a YadaPrivate class will typically be found in Yada.cpp. Yada.h and Yada will be added later (follow the blocks change)
Comment 6 Arvid Nilsson 2012-03-14 10:10:59 PDT
I'll have to try again tomorrow, the patch is not coming out right... I must be preparing it for upstream submission the wrong way.
Comment 7 Arvid Nilsson 2012-03-16 17:09:23 PDT
Created attachment 132419 [details]
Patch
Comment 8 Rob Buis 2012-03-16 17:24:03 PDT
Comment on attachment 132419 [details]
Patch

LGTM.
Comment 9 WebKit Review Bot 2012-03-16 17:41:34 PDT
Comment on attachment 132419 [details]
Patch

Clearing flags on attachment: 132419

Committed r111099: <http://trac.webkit.org/changeset/111099>
Comment 10 WebKit Review Bot 2012-03-16 17:41:40 PDT
All reviewed patches have been landed.  Closing bug.