Bug 80904 - Make ApplicationCacheHost::canCacheInPageCache() non-const.
Summary: Make ApplicationCacheHost::canCacheInPageCache() non-const.
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Peters
Depends on:
Reported: 2012-03-12 15:57 PDT by Gavin Peters
Modified: 2012-03-13 08:19 PDT (History)
4 users (show)

See Also:

Patch (3.94 KB, patch)
2012-03-12 15:58 PDT, Gavin Peters
no flags Details | Formatted Diff | Diff
Patch (3.86 KB, patch)
2012-03-12 16:41 PDT, Gavin Peters
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Peters 2012-03-12 15:57:06 PDT
Make ApplicationCacheHost::canCacheInPageCache() non-const.
Comment 1 Gavin Peters 2012-03-12 15:58:56 PDT
Created attachment 131432 [details]
Comment 2 Gavin Peters 2012-03-12 16:00:30 PDT
A const pointer to a large object like ApplicationCacheHost is not our standard practice; so remove this (implicit) one.  See also https://bugs.webkit.org/show_bug.cgi?id=80898
Comment 3 Alexey Proskuryakov 2012-03-12 16:05:38 PDT
Comment on attachment 131432 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=131432&action=review

> Source/WebKit/chromium/ChangeLog:14
> +        * loader/appcache/ApplicationCacheHost.h:
> +        (ApplicationCacheHost):

I'm not seeing this file in the patch.
Comment 4 Gavin Peters 2012-03-12 16:41:56 PDT
Created attachment 131449 [details]
Comment 5 Gavin Peters 2012-03-12 16:42:33 PDT
Comment on attachment 131449 [details]

ap, that's because that file doesn't exist.  I've uploaded a new version that fixes that, and I'll cq+ it with your review tomorrow AM.
Comment 6 WebKit Review Bot 2012-03-13 08:19:00 PDT
Comment on attachment 131449 [details]

Clearing flags on attachment: 131449

Committed r110564: <http://trac.webkit.org/changeset/110564>
Comment 7 WebKit Review Bot 2012-03-13 08:19:04 PDT
All reviewed patches have been landed.  Closing bug.