Make ApplicationCacheHost::isApplicationCacheEnabled() const.
Created attachment 131424 [details] Patch
This patch make this ApplicationCacheHost method const; I'm shortly going to add code to chromium that follows a const pointer, and the function was logically already const.
Comment on attachment 131424 [details] Patch We generally try to not have const pointers to large objects like this one, because it simply doesn't make sense. So, it would be slightly better to fix chromium side to not keep a const pointer. But there is no harm in this patch either. Note that the existing line below is worse: > DocumentLoader* documentLoader() const { return m_documentLoader; } This is basically a sneaky way to remove constness (DocumentLoader owns ApplicationCacheHost and a lot more).
You're right. Let's get it right.