RESOLVED WONTFIX 80898
Make ApplicationCacheHost::isApplicationCacheEnabled() const. 
https://bugs.webkit.org/show_bug.cgi?id=80898
Summary Make ApplicationCacheHost::isApplicationCacheEnabled() const.
Gavin Peters
Reported 2012-03-12 15:16:40 PDT
Make ApplicationCacheHost::isApplicationCacheEnabled() const.
Attachments
Patch (3.77 KB, patch)
2012-03-12 15:19 PDT, Gavin Peters 		gavinp: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Peters
Comment 1 2012-03-12 15:19:56 PDT
Created attachment 131424 [details] Patch
Gavin Peters
Comment 2 2012-03-12 15:25:44 PDT
This patch make this ApplicationCacheHost method const; I'm shortly going to add code to chromium that follows a const pointer, and the function was logically already const.
Alexey Proskuryakov
Comment 3 2012-03-12 15:30:35 PDT
Comment on attachment 131424 [details] Patch We generally try to not have const pointers to large objects like this one, because it simply doesn't make sense. So, it would be slightly better to fix chromium side to not keep a const pointer. But there is no harm in this patch either. Note that the existing line below is worse: > DocumentLoader* documentLoader() const { return m_documentLoader; } This is basically a sneaky way to remove constness (DocumentLoader owns ApplicationCacheHost and a lot more).
Gavin Peters
Comment 4 2012-03-12 15:48:40 PDT
You're right. Let's get it right.
Note You need to log in before you can comment on or make changes to this bug.