Bug 80623 - Recent changes to chromium.py etc. broke chromium_android.py
Summary: Recent changes to chromium.py etc. broke chromium_android.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords:
Depends on: 80642
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-08 11:48 PST by Xianzhu Wang
Modified: 2012-03-12 09:42 PDT (History)
5 users (show)

See Also:


Attachments
patch (2.33 KB, patch)
2012-03-08 15:14 PST, Xianzhu Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-03-08 11:48:55 PST
Dirk made some changes to chromium.py etc. causing some incompatibilities of chromium_android.py, e.g. _start() and cmd_line(), etc. Should change chromium_android.py accordingly.
Comment 1 Xianzhu Wang 2012-03-08 15:14:52 PST
Created attachment 130916 [details]
patch
Comment 2 Dirk Pranke 2012-03-08 15:16:11 PST
Comment on attachment 130916 [details]
patch

Sorry for missing this ... I should've made these changes as part of my other patch :(.
Comment 3 WebKit Review Bot 2012-03-08 20:28:47 PST
Comment on attachment 130916 [details]
patch

Clearing flags on attachment: 130916

Committed r110258: <http://trac.webkit.org/changeset/110258>
Comment 4 WebKit Review Bot 2012-03-08 20:28:51 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Tony Chang 2012-03-12 09:36:46 PDT
Should we add a unittest for this?
Comment 6 Xianzhu Wang 2012-03-12 09:42:55 PDT
(In reply to comment #5)
> Should we add a unittest for this?

Agreed. https://bugs.webkit.org/show_bug.cgi?id=80852