Bug 80852 - [Chromium-android] Add unit test for Android layout test script (chromium_android.py)
Summary: [Chromium-android] Add unit test for Android layout test script (chromium_and...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hao Zheng
URL:
Keywords:
Depends on:
Blocks: 66687
  Show dependency treegraph
 
Reported: 2012-03-12 09:42 PDT by Xianzhu Wang
Modified: 2012-05-09 08:27 PDT (History)
7 users (show)

See Also:


Attachments
Patch (7.71 KB, patch)
2012-05-09 01:06 PDT, Hao Zheng
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-03-12 09:42:04 PDT
<EOM>
Comment 1 Hao Zheng 2012-05-09 01:06:42 PDT
Created attachment 140882 [details]
Patch
Comment 2 Adam Barth 2012-05-09 08:17:25 PDT
Comment on attachment 140882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140882&action=review

Thanks for the tests!

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:121
> +if __name__ == '__main__':
> +    unittest.main()

We usually skip these in new unit test files.
Comment 3 WebKit Review Bot 2012-05-09 08:27:16 PDT
Comment on attachment 140882 [details]
Patch

Clearing flags on attachment: 140882

Committed r116526: <http://trac.webkit.org/changeset/116526>
Comment 4 WebKit Review Bot 2012-05-09 08:27:21 PDT
All reviewed patches have been landed.  Closing bug.