If a response is cached with ETag, it cannot be fetched from cache with XMLHttpRequest. To reproduce, 1. unpack attached files into LayoutTests/http/tests, 2. run-webkit-httpd, 3. Open http://127.0.0.1:8000/304.html, 4. Follow instructions in test.
Created attachment 130726 [details] test case
<rdar://problem/10979550>
(In reply to comment #2) > <rdar://problem/10979550> (In reply to comment #0) > If a response is cached with ETag, it cannot be fetched from cache with XMLHttpRequest. > > To reproduce, > 1. unpack attached files into LayoutTests/http/tests, > 2. run-webkit-httpd, > 3. Open http://127.0.0.1:8000/304.html, > 4. Follow instructions in test. I'm wondering if we should perhaps switch to requiring identical headers except a whitelist, rather than presuming reuse is ok with a blacklist, as proposed in https://bugs.webkit.org/show_bug.cgi?id=80334 What do you think?
This sounds reasonable to me, but I don't see the connection to this bug. Here, no response is delivered at all, not even a stale one.
(In reply to comment #4) > This sounds reasonable to me, but I don't see the connection to this bug. Here, no response is delivered at all, not even a stale one. Sorry, I misread the report. That's bad, will look at this today.
(In reply to comment #5) > (In reply to comment #4) > > This sounds reasonable to me, but I don't see the connection to this bug. Here, no response is delivered at all, not even a stale one. > > Sorry, I misread the report. That's bad, will look at this today. This appears to be more general than just etags. When the content of a cached xhr is valid but empty, we exit too early in CachedRawResource::didAddClient() and leave the load hanging.
Re-titling accordingly.
Created attachment 130905 [details] patch
Landed: http://trac.webkit.org/changeset/110301