Bug 80334 - Refine CachedRawResource reuse based on request headers
Summary: Refine CachedRawResource reuse based on request headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-05 15:11 PST by Nate Chapin
Modified: 2012-04-16 17:22 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2012-03-05 15:11:01 PST
So far, I've fixed http://trac.webkit.org/changeset/108576, which was allowing CachedResource re-use when the two requests' Range headers weren't identical.

There are other, similar cases, where headers need to be the same (e.g., "Authorization" was recently pointed out to me). I'm debating whether to continue the whack-a-mole game of finding and fixing these headers that need to match to be cahceable. The alternative is to switch to requiring all headers to match except for a whitelist (e.g., I'm pretty sure we still want a cache hit even if the referrers don't match).

Thoughts are appreciated.
Comment 1 Nate Chapin 2012-04-16 17:22:51 PDT
This should have been resolved by http://trac.webkit.org/changeset/110608