RESOLVED FIXED80523
[chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D() 
https://bugs.webkit.org/show_bug.cgi?id=80523
Summary [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::crea...
James Robinson
Reported 2012-03-07 11:09:14 PST
[chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
Attachments
Patch (7.21 KB, patch)
2012-03-07 11:11 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (7.17 KB, patch)
2012-03-07 11:21 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
fix typo (7.17 KB, patch)
2012-03-07 11:33 PST, James Robinson 		fishd: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-03-07 11:11:15 PST
Created attachment 130652 [details] Patch
James Robinson
Comment 2 2012-03-07 11:21:17 PST
Created attachment 130654 [details] Patch
James Robinson
Comment 3 2012-03-07 11:23:01 PST
This has to land after https://chromiumcodereview.appspot.com/9623009/, since that's the chromium-side implementation of the new WebViewClient functions. https://chromiumcodereview.appspot.com/9623009/ has to land after http://trac.webkit.org/changeset/110075 rolls into Chromium DEPS since it's a WebKit side caller of the deprecated function.
WebKit Review Bot
Comment 4 2012-03-07 11:24:06 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Antoine Labour
Comment 5 2012-03-07 11:25:56 PST
LGTM
Kenneth Russell
Comment 6 2012-03-07 11:27:20 PST
Comment on attachment 130654 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130654&action=review This looks good but as you've pointed out can't be r+'d yet due to dependencies. One minor nit. > Source/WebKit/chromium/public/WebViewClient.h:116 > + // Creates a graphics context that renders to a the client's WebView. "that renders to the client's"
James Robinson
Comment 7 2012-03-07 11:33:27 PST
Created attachment 130657 [details] fix typo
Darin Fisher (:fishd, Google)
Comment 8 2012-03-07 12:18:10 PST
Comment on attachment 130657 [details] fix typo R+ in advance
WebKit Review Bot
Comment 9 2012-03-09 18:57:17 PST
Comment on attachment 130657 [details] fix typo Rejecting attachment 130657 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /chromium/src/WebViewImpl.cpp Hunk #1 FAILED at 3222. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/src/WebViewImpl.cpp.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/chromium/WebViewHost.cpp patching file Tools/DumpRenderTree/chromium/WebViewHost.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Darin Fish..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11892929
James Robinson
Comment 10 2012-03-09 19:11:36 PST
Committed r110364: <http://trac.webkit.org/changeset/110364>
James Robinson
Comment 11 2012-03-14 15:58:28 PDT
Committed r110773: <http://trac.webkit.org/changeset/110773>
Note You need to log in before you can comment on or make changes to this bug.