Bug 80523 - [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
Summary: [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::crea...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on: 80521
Blocks:
  Show dependency tree / graph
 
Reported: 2012-03-07 11:09 PST by James Robinson
Modified: 2012-03-14 15:58 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.21 KB, patch)
2012-03-07 11:11 PST, James Robinson 		no flags Details | Formatted Diff | Diff
Patch (7.17 KB, patch)
2012-03-07 11:21 PST, James Robinson 		no flags Details | Formatted Diff | Diff
fix typo (7.17 KB, patch)
2012-03-07 11:33 PST, James Robinson 		fishd: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-03-07 11:09:14 PST 
[chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
Comment 1 James Robinson 2012-03-07 11:11:15 PST 
Created attachment 130652 [details]
Patch
Comment 2 James Robinson 2012-03-07 11:21:17 PST 
Created attachment 130654 [details]
Patch
Comment 3 James Robinson 2012-03-07 11:23:01 PST 
This has to land after https://chromiumcodereview.appspot.com/9623009/, since that's the chromium-side implementation of the new WebViewClient functions. https://chromiumcodereview.appspot.com/9623009/ has to land after http://trac.webkit.org/changeset/110075 rolls into Chromium DEPS since it's a WebKit side caller of the deprecated function.
Comment 4 WebKit Review Bot 2012-03-07 11:24:06 PST 
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 5 Antoine Labour 2012-03-07 11:25:56 PST 
LGTM
Comment 6 Kenneth Russell 2012-03-07 11:27:20 PST 
Comment on attachment 130654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=130654&action=review

This looks good but as you've pointed out can't be r+'d yet due to dependencies. One minor nit.

> Source/WebKit/chromium/public/WebViewClient.h:116
> +    // Creates a graphics context that renders to a the client's WebView.

"that renders to the client's"
Comment 7 James Robinson 2012-03-07 11:33:27 PST 
Created attachment 130657 [details]
fix typo
Comment 8 Darin Fisher (:fishd, Google) 2012-03-07 12:18:10 PST 
Comment on attachment 130657 [details]
fix typo

R+ in advance
Comment 9 WebKit Review Bot 2012-03-09 18:57:17 PST 
Comment on attachment 130657 [details]
fix typo

Rejecting attachment 130657 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/chromium/src/WebViewImpl.cpp
Hunk #1 FAILED at 3222.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/src/WebViewImpl.cpp.rej
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/chromium/WebViewHost.cpp
patching file Tools/DumpRenderTree/chromium/WebViewHost.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Darin Fish..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11892929
Comment 10 James Robinson 2012-03-09 19:11:36 PST 
Committed r110364: <http://trac.webkit.org/changeset/110364>
Comment 11 James Robinson 2012-03-14 15:58:28 PDT 
Committed r110773: <http://trac.webkit.org/changeset/110773>