Bug 80521 - [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
Summary: [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks: 80523
  Show dependency tree / graph
 
Reported: 2012-03-07 10:57 PST by James Robinson
Modified: 2012-03-07 11:18 PST (History)
6 users (show)

See Also:

Attachments
Patch (8.07 KB, patch)
2012-03-07 11:01 PST, James Robinson 		kbr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-03-07 10:57:33 PST 
[chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
Comment 1 James Robinson 2012-03-07 11:01:07 PST 
Created attachment 130649 [details]
Patch
Comment 2 James Robinson 2012-03-07 11:03:42 PST 
I'm planning to deprecate the bool renderDirectlyToWebView parameter from WebViewClient::createGraphicsContext3D() and have the rule be that onscreen contexts are created through WebViewClient and offscreen contexts are created through WebKitPlatformSupport.  This is the only caller on the WebKit side.

Pepper plugins will continue to share resources with an out-of-band mechanism exposed to chromium code only.
Comment 3 Kenneth Russell 2012-03-07 11:08:43 PST 
Comment on attachment 130649 [details]
Patch

Looks good.
Comment 4 James Robinson 2012-03-07 11:18:35 PST 
Committed r110075: <http://trac.webkit.org/changeset/110075>