Add the ENABLE_LEGACY_NOTIFICATIONS flag for all ports that currently support NOTIFICATIONS.
<rdar://problem/11001341>
Created attachment 130714 [details] Patch
Comment on attachment 130714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130714&action=review > Source/WebCore/GNUmakefile.am:489 > +FEATURE_DEFINES += ENABLE_LEGACY_NOTIFICATIONS=1 > FEATURE_DEFINES += ENABLE_NOTIFICATIONS=1 > +webcore_cppflags += -DENABLE_LEGACY_NOTIFICATIONS=1 > webcore_cppflags += -DENABLE_NOTIFICATIONS=1 This is sort of a nit but it would be cleaner to do: FEATURE_DEFINES += ENABLE_NOTIFICATIONS=1 ENABLE_LEGACY_NOTIFICATIONS=1 webcore_cppflags += -DENABLE_NOTIFICATIONS=1 -DENABLE_LEGACY_NOTIFICATIONS=1
Created attachment 130778 [details] Patch Incorporated Martin's feedback
Anyone else?
Comment on attachment 130778 [details] Patch The mechanics of this patch appear to be correct. I assume from the webkit-dev thread that you have buy-in from the folks who work on notifications that this is the right path to take.
Committed r110217: <http://trac.webkit.org/changeset/110217>
The commit was wrong-- it only changed the Changelogs. The real commit is r110311, and I removed the change to the Changelogs. <http://trac.webkit.org/changeset/110311>